Skip to content

Allow to opt-out from Scorecard's olm-status-descriptors-test missing Status warning #6564

Open

Description

@clobrano

Feature Request

Describe the problem you need a feature to resolve.

This feature request revolves around Scorecard's olm-status-descriptors-test, which generates warnings for Custom Resource Definitions lacking a .Status definition. This warning is intended to encourage authors to include a .Status section, even though it's not strictly mandatory 1.

However, a significant problem arises when pipelines relying on this test continue to produce warnings for CRDs that legitimately do not need a .Status section, requiring to inspect any report to verify if the warning is a new entry or the known one.

Describe the solution you'd like.

It would be beneficial to introduce an option for opting out of these warnings for specific CRDs.

Pros:

  • Without any intentional intervention, the test will continue to promote best practices and adherence to conventions.
  • In projects with multiple CRDs, the test can still be applied comprehensively to those that require and possess a .Status section.

Cons:

  • The only potential downside is that once this decision is made, authors must remember to remove the opt-out code/flag if the CRD's requirements change.

Activity

  1. oceanc80 commented on Sep 11, 2023

    @oceanc80
    Collaborator

    Per a suggestion from @joelanford, we could explore some sort of silencing mechanism similar to golangci-lint's nolint directive: https://golangci-lint.run/usage/false-positives/#nolint-directive

  2. varshaprasad96 commented on Sep 11, 2023

    @varshaprasad96
    Member

    This seems a reasonable request. We would like to mark this as triage-accepted.

  3. added
    scorecardIssue relates to the scorecard subcomponent
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Sep 11, 2023
  4. added this to the Backlog milestone on Sep 11, 2023
  5. openshift-bot commented on Dec 11, 2023

    @openshift-bot

    Issues go stale after 90d of inactivity.

    Mark the issue as fresh by commenting /remove-lifecycle stale.
    Stale issues rot after an additional 30d of inactivity and eventually close.
    Exclude this issue from closing by commenting /lifecycle frozen.

    If this issue is safe to close now please do so with /close.

    /lifecycle stale

  6. added
    lifecycle/staleDenotes an issue or PR has remained open with no activity and has become stale.
    on Dec 11, 2023
  7. clobrano commented on Dec 11, 2023

    @clobrano
    Author

    Please don't close it 😄

  8. varshaprasad96 commented on Dec 11, 2023

    @varshaprasad96
    Member

    /lifecycle frozen

    @clobrano This issue was added to the backlog, since we don't have enough contributors in the project to help us with implementing the feature. Adding lifecycle/frozen label so that it doesn't get closed and can be picked up by the community.

  9. added
    lifecycle/frozenIndicates that an issue or PR should not be auto-closed due to staleness.
    and removed
    lifecycle/staleDenotes an issue or PR has remained open with no activity and has become stale.
    on Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.lifecycle/frozenIndicates that an issue or PR should not be auto-closed due to staleness.scorecardIssue relates to the scorecard subcomponent

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions