Existing legacy rules are not displayed correctly in the new rules (allow/block symbol). German and other translations.

[hartmann-daniel]

Important notices

Before you add a new report, we ask you kindly to acknowledge the following:

• I have read the contributing guidelines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
• I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Describe the bug

After updating to version 26.1, a display error was noticed in the new rules. This only affects translated versions, in my case, German.

The legacy rules were transferred to the new rules using the wizard. The existing automatic rules were apparently not exported or imported, but rather loaded in the code via MVC. This is where the display error occurred. The Allow/Deny symbol is always set to Allow, which is obviously incorrect for rules that are set to Default Deny. See screenshot.

To Reproduce

Steps to reproduce the behavior:

1. Use a version prior to 26.1
2. Set the language to German
3. Update to 26.1
4. Export the existing rules using the Migration Assistant
5. Import the exported rules using the Migration Assistant
6. Open "New" under Firewall Rules
7. Inspect the automatic rules.
8. You will see, for example, that the "Default deny / state violation rule" is marked with the "Allow" symbol.

Expected behavior

The symbol should be the Deny symbol.

Describe alternatives you considered

When querying api/firewall/filter/search_rule/, there appears to be an unintended translation of the action field. With legacy rules, the field is translated into German, which I believe is a bug. With MVC rules, no translation is performed; instead, the %action field is added as a translated version.

Perhaps this is a possible solution? Not tested!
hartmann-daniel@d94fabb

Screenshots

English Version (no Problem):

German Version (Problem in First Line)

Relevant log files

No

Additional context

No

Environment

Software version used and hardware type if relevant, e.g.:
OPNsense 26.1.7_1-amd64

[Monviech]

core/src/opnsense/mvc/app/views/OPNsense/Firewall/filter_rule.volt

Lines 445 to 452 in b94cad4

	// Action
	if (row.action.toLowerCase() === "block") {
	result += '<i class="fa fa-times fa-fw text-danger" data-toggle="tooltip" title="{{ lang._("Block") }}"></i> ';
	} else if (row.action.toLowerCase() === "reject") {
	result += '<i class="fa fa-times-circle fa-fw text-danger" data-toggle="tooltip" title="{{ lang._("Reject") }}"></i> ';
	} else {
	result += '<i class="fa fa-play fa-fw text-success" data-toggle="tooltip" title="{{ lang._("Pass") }}"></i> ';
	}

Right now this uses action and not %action to decide the rule icon. When nothing matches it falls back to pass.

Though it looks like %action has the translated value, action has the original value:

MVC:

            "action": "pass",
            "%action": "Pass",

Legacy:

            "action": "Pass",

EDIT: Here is where it originates, so probably needs a look here:

core/src/opnsense/scripts/filter/list_non_mvc_rules.php

Line 77 in b94cad4

$rule['action'] = $rule['action'] ?? 'pass';

[fichtner]

Why not add % labels there?