[3.0.0] ClassNotFoundException: org.apache.commons.logging.LogFactory

[ben-manes]

When upgrading it looks like a transitive dependency is not being pulled through anymore. Adding the dependency explicitly fixes my build, so fyi

OSGiTest > sanity FAILED
    java.lang.NoClassDefFoundError: org/apache/commons/logging/LogFactory
        at shaded.org.apache.http.conn.ssl.AbstractVerifier.<init>(AbstractVerifier.java:61)
        at shaded.org.apache.http.conn.ssl.AllowAllHostnameVerifier.<init>(AllowAllHostnameVerifier.java:44)
        at shaded.org.apache.http.conn.ssl.AllowAllHostnameVerifier.<clinit>(AllowAllHostnameVerifier.java:46)
        at shaded.org.apache.http.conn.ssl.SSLConnectionSocketFactory.<clinit>(SSLConnectionSocketFactory.java:151)
        at shaded.org.eclipse.aether.transport.http.GlobalState.newConnectionManager(GlobalState.java:169)
        at shaded.org.eclipse.aether.transport.http.LocalState.<init>(LocalState.java:57)
        at shaded.org.eclipse.aether.transport.http.HttpTransporter.<init>(HttpTransporter.java:197)
        at shaded.org.eclipse.aether.transport.http.HttpTransporterFactory.newInstance(HttpTransporterFactory.java:95)
        at shaded.org.eclipse.aether.internal.impl.DefaultTransporterProvider.newTransporter(DefaultTransporterProvider.java:94)
        at shaded.org.eclipse.aether.connector.basic.BasicRepositoryConnector.<init>(BasicRepositoryConnector.java:128)
        at shaded.org.eclipse.aether.connector.basic.BasicRepositoryConnectorFactory.newInstance(BasicRepositoryConnectorFactory.java:172)
        at shaded.org.eclipse.aether.internal.impl.DefaultRepositoryConnectorProvider.newRepositoryConnector(DefaultRepositoryConnectorProvider.java:122)
        at shaded.org.eclipse.aether.internal.impl.DefaultArtifactResolver.performDownloads(DefaultArtifactResolver.java:536)
        at shaded.org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolve(DefaultArtifactResolver.java:449)
        at shaded.org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolveArtifacts(DefaultArtifactResolver.java:261)
        at shaded.org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolveArtifact(DefaultArtifactResolver.java:243)
        at shaded.org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveArtifact(DefaultRepositorySystem.java:278)
        at org.ops4j.pax.url.mvn.internal.AetherBasedResolver.resolve(AetherBasedResolver.java:551)
        at org.ops4j.pax.url.mvn.internal.AetherBasedResolver.resolve(AetherBasedResolver.java:404)
        at org.ops4j.pax.url.mvn.internal.AetherBasedResolver.resolve(AetherBasedResolver.java:351)
        at org.ops4j.pax.url.mvn.internal.AetherBasedResolver.resolve(AetherBasedResolver.java:321)
        at org.ops4j.pax.url.mvn.internal.AetherBasedResolver.resolve(AetherBasedResolver.java:311)
        at org.ops4j.pax.url.mvn.internal.Connection.getInputStream(Connection.java:118)
        at org.apache.felix.framework.util.SecureAction.getURLConnectionInputStream(SecureAction.java:677)
        at org.apache.felix.framework.cache.JarRevision.initialize(JarRevision.java:166)
        at org.apache.felix.framework.cache.JarRevision.<init>(JarRevision.java:76)
        at org.apache.felix.framework.cache.BundleArchive.createRevisionFromLocation(BundleArchive.java:819)
        at org.apache.felix.framework.cache.BundleArchive.reviseInternal(BundleArchive.java:491)
        at org.apache.felix.framework.cache.BundleArchive.<init>(BundleArchive.java:155)
        at org.apache.felix.framework.cache.BundleCache.create(BundleCache.java:457)
        at org.apache.felix.framework.Felix.installBundle(Felix.java:3254)
        at org.apache.felix.framework.BundleContextImpl.installBundle(BundleContextImpl.java:147)
        at org.apache.felix.framework.BundleContextImpl.installBundle(BundleContextImpl.java:120)
        at org.ops4j.pax.exam.nat.internal.NativeTestContainer.installAndStartBundles(NativeTestContainer.java:340)
        at org.ops4j.pax.exam.nat.internal.NativeTestContainer.start(NativeTestContainer.java:209)
        at org.ops4j.pax.exam.spi.reactors.AllConfinedStagedReactor.invoke(AllConfinedStagedReactor.java:80)
        at org.ops4j.pax.exam.junit.impl.ProbeRunner$2.evaluate(ProbeRunner.java:267)
        at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
        at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
        at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
        at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
        at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
        at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
        at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
        at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
        at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:[293])
        at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
        at org.ops4j.pax.exam.junit.impl.ProbeRunner.run(ProbeRunner.java:98)
        at org.ops4j.pax.exam.junit.PaxExam.run(PaxExam.java:93)
        at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.runTestClass(JUnitTestClassExecutor.java:112)
        at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.execute(JUnitTestClassExecutor.java:58)
        at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.execute(JUnitTestClassExecutor.java:40)
        at org.gradle.api.internal.tasks.testing.junit.AbstractJUnitTestClassProcessor.processTestClass(AbstractJUnitTestClassProcessor.java:54)
        at org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:53)
        at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
        at java.base/java.lang.reflect.Method.invoke(Method.java:565)
        at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:36)
        at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
        at org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:33)
        at org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:92)
        at jdk.proxy2/jdk.proxy2.$Proxy6.processTestClass(Unknown Source)
        at org.gradle.api.internal.tasks.testing.worker.TestWorker$2.run(TestWorker.java:183)
        at org.gradle.api.internal.tasks.testing.worker.TestWorker.executeAndMaintainThreadName(TestWorker.java:132)
        at org.gradle.api.internal.tasks.testing.worker.TestWorker.execute(TestWorker.java:103)
        at org.gradle.api.internal.tasks.testing.worker.TestWorker.execute(TestWorker.java:63)
        at org.gradle.process.internal.worker.child.ActionExecutionWorker.execute(ActionExecutionWorker.java:56)
        at org.gradle.process.internal.worker.child.SystemApplicationClassLoaderWorker.call(SystemApplicationClassLoaderWorker.java:121)
        at org.gradle.process.internal.worker.child.SystemApplicationClassLoaderWorker.call(SystemApplicationClassLoaderWorker.java:71)
        at worker.org.gradle.process.internal.worker.GradleWorkerMain.run(GradleWorkerMain.java:69)
        at worker.org.gradle.process.internal.worker.GradleWorkerMain.main(GradleWorkerMain.java:74)

        Caused by:
        java.lang.ClassNotFoundException: org.apache.commons.logging.LogFactory
            at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:580)
            at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:490)
            ... 70 more

[grgrzybek]

At first glance indeed - pax-url-aether 3.0.0 has optional Import-Package for org.apache.commons.logging.
It is not present in pax-url-aether 2.6.16, however the version of httpclient library used (and embedded in the bundle) is the same, so shaded.org.apache.http.conn.ssl.AbstractVerifier should also attempt to load this missing class.

Did you (transitively perhaps?) have commons-logging included in the classpath before the upgrade?

Pax URL is meant to be used with Pax Logging that provides all necessary logging facade APIs...

[ben-manes]

When going back to the previous commit and viewing the dependency tree, I only see commons-logging coming through org.apache.httpcomponents:httpclient which is used by sigstoreClientClasspath and checkstyle, neither of which are on the test's classpath. It may very well be that I have a frankenstein buld for PaxExam as I introduced it to avoid regressions in providing an OSGi bundle but am completely inexperienced with that ecosystem (example test, example build). You are welcome to close this as it was merely a friendly notice if an actual issue, and I did the naive addition of commons-logging which solved it for my needs.

[jbonofre]

@ben-manes Thanks for update. Let me double check if the dep is not leaking in bnd 😄

[ben-manes]

oh, I kept looking for commons-logging. The reason is because you're now hiding the slf4j bridge which reimplements that package. That was marked as compile and is now test scope according to the pom on maven central. I think its better now, but was not obvious to me. Since this is a major version the breakage is perfectly fine, and at best maybe a comment if you have release notes.

|    +--- org.ops4j.pax.url:pax-url-aether:2.6.14 -> 2.6.16
|    |    +--- org.ops4j.pax.url:pax-url-aether-support:2.6.16
|    |    |    \--- org.apache.maven.resolver:maven-resolver-impl:1.8.2
|    |    |         +--- org.apache.maven.resolver:maven-resolver-api:1.8.2
|    |    |         +--- org.apache.maven.resolver:maven-resolver-spi:1.8.2
|    |    |         |    \--- org.apache.maven.resolver:maven-resolver-api:1.8.2
|    |    |         +--- org.apache.maven.resolver:maven-resolver-named-locks:1.8.2
|    |    |         |    \--- org.slf4j:slf4j-api:1.7.36 -> 2.0.17 (*)
|    |    |         +--- org.apache.maven.resolver:maven-resolver-util:1.8.2
|    |    |         |    \--- org.apache.maven.resolver:maven-resolver-api:1.8.2
|    |    |         +--- org.apache.commons:commons-lang3:3.12.0 -> 3.17.0
|    |    |         +--- javax.annotation:javax.annotation-api:1.3.2
|    |    |         \--- org.slf4j:slf4j-api:1.7.36 -> 2.0.17 (*)
|    |    \--- org.slf4j:jcl-over-slf4j:1.7.32 -> 2.0.17 (*)

[grgrzybek]

Thank you @ben-manes for saving me from debugging gradle build ;)
I'm a hard core Maven advocate since Maven 1 and delicately speaking I try to avoid Gradle.

It took me a while to realize the dependency is expressed in toml file:

osgi-test-runtime = ["felix-framework", "felix-scr", "osgi-function",
  "osgi-promise", "pax-exam-container-native", "pax-exam-link-mvn", "pax-url-aether"]

if you were getting this missing package (org.apache.commons.logging) through jcl-over-slf4j bridge, then indeed you should not rely on that.
However compile was changed to test in 01a06f1 7 years ago...

So yes - please include commons-logging-api dependency (or for Pax Exam based tests it's better to include Pax Logging API).

Can we close this issue as explained?

[ben-manes]

The central pom shows it as compile scope in 2.6.16 which is from 2025. It’s only test scope in the new 3.0 release. If it’s needed for pax-exam to work then it might have been intentionally at that scope. Either way it’s not worth our time and the issue is meant to help anyone else upgrading.

org.ops4j.pax.url/pax-url-aether/pom.xml

Lines 108 to 112 in fd2d532

	<dependency>
	<groupId>org.slf4j</groupId>
	<artifactId>jcl-over-slf4j</artifactId>
	<scope>compile</scope>
	</dependency>

[grgrzybek]

Now I see! It is purely my mistake... I've created url-3.0.x branch in late 2023 and then stopped. So recently I merged it with main to get all recent fixes from main (2.6.x) branch and I had some merge conflicts where I collapsed:

        <dependency>
            <groupId>org.slf4j</groupId>
            <artifactId>jcl-over-slf4j</artifactId>
            <scope>compile</scope>
        </dependency>
        <dependency>
            <groupId>ch.qos.logback</groupId>
            <artifactId>logback-classic</artifactId>
            <scope>test</scope>
        </dependency>

into:

        <dependency>
            <groupId>org.slf4j</groupId>
            <artifactId>jcl-over-slf4j</artifactId>
            <scope>test</scope>
        </dependency>

My bad - I'll actually bring it back to fix compatibility. Thanks for the report!

[grgrzybek]

But please don't expect release 3.0.1 with just this fix.
I'll rather review the dependencies and ensure that Maven deps and generated Import-Package header are more consistent.

We should not rely on presence/absence of jcl-over-slf4j bridge at all.

[ben-manes]

Oh of course not. It’s all perfectly fine and I am certainly not blocked or expecting anything.

Thanks for the testing framework, it’s helped me from breaking osgi users!

[grgrzybek]

Sorry for delay - I have to get back to Pax URL to fix other issues, so I should release 3.0.1 soon.