Skip to content

Commit 6e9aadd

Browse files
mhamzak008Zafer Genckaya
authored and
Zafer Genckaya
committed
bug fix: request field of http_metrics is being correctly populated now
1 parent fa534d2 commit 6e9aadd

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

opsgenie_sdk/rest.py

+4-2
Original file line numberDiff line numberDiff line change
@@ -238,6 +238,8 @@ def request(self, method, url, query_params=None, headers=None,
238238
logger.debug("response body: %s", r.data)
239239

240240
data = self.decodeResponse(r.data)
241+
http_metrics_request = [('method', method), ('url', url), ('query_params', query_params), ('headers', headers),
242+
('body', body), ('post_params', post_params)]
241243
if "message" not in data:
242244
self.http_metric.build_metric(transaction_id=self.configuration.metrics_transaction_id,
243245
duration=data["took"],
@@ -246,7 +248,7 @@ def request(self, method, url, query_params=None, headers=None,
246248
error=False,
247249
status=r.status,
248250
status_code=r.status,
249-
request=query_params)
251+
request=http_metrics_request)
250252
else:
251253
self.http_metric.build_metric(transaction_id=self.configuration.metrics_transaction_id,
252254
duration=data["took"],
@@ -255,7 +257,7 @@ def request(self, method, url, query_params=None, headers=None,
255257
error=True,
256258
status=r.status,
257259
status_code=r.status,
258-
request=query_params)
260+
request=http_metrics_request)
259261

260262
should_retry = self.__checkHttpCode__(r.status)
261263
if should_retry:

templates/rest.mustache

+4-2
Original file line numberDiff line numberDiff line change
@@ -229,6 +229,8 @@ class RESTClientObject(object):
229229
logger.debug("response body: %s", r.data)
230230

231231
data = self.decodeResponse(r.data)
232+
http_metrics_request = [('method', method), ('url', url), ('query_params', query_params), ('headers', headers),
233+
('body', body), ('post_params', post_params)]
232234
if "message" not in data:
233235
self.http_metric.build_metric(transaction_id=self.configuration.metrics_transaction_id,
234236
duration=data["took"],
@@ -237,7 +239,7 @@ class RESTClientObject(object):
237239
error=False,
238240
status=r.status,
239241
status_code=r.status,
240-
request=query_params)
242+
request=http_metrics_request)
241243
else:
242244
self.http_metric.build_metric(transaction_id=self.configuration.metrics_transaction_id,
243245
duration=data["took"],
@@ -246,7 +248,7 @@ class RESTClientObject(object):
246248
error=True,
247249
status=r.status,
248250
status_code=r.status,
249-
request=query_params)
251+
request=http_metrics_request)
250252

251253
should_retry = self.__checkHttpCode__(r.status)
252254
if should_retry:

0 commit comments

Comments
 (0)