You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There seems to be an inconsistency with the comment here and wanted to make sure that it's not an issue in other parts of the code (which I haven't reviewed yet) that calculate the exercise window.
If _windowSize is a UNIX time, then does it mean that the the window is actually: FROM [_windowSize] to [expiry]?
More likely, _windowSize is number of seconds from expiry...
The text was updated successfully, but these errors were encountered:
https://github.com/aparnakr/OptionsProtocol/blob/9363067b23278cd6d919cc0dad8ae0d4b489491f/contracts/OptionsFactory.sol#L48
There seems to be an inconsistency with the comment here and wanted to make sure that it's not an issue in other parts of the code (which I haven't reviewed yet) that calculate the exercise window.
If _windowSize is a UNIX time, then does it mean that the the window is actually: FROM [_windowSize] to [expiry]?
More likely, _windowSize is number of seconds from expiry...
The text was updated successfully, but these errors were encountered: