Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is _windowSize UNIX time or seconds? #101

Open
kangaroosterus opened this issue Feb 12, 2020 · 0 comments
Open

Is _windowSize UNIX time or seconds? #101

kangaroosterus opened this issue Feb 12, 2020 · 0 comments

Comments

@kangaroosterus
Copy link

https://github.com/aparnakr/OptionsProtocol/blob/9363067b23278cd6d919cc0dad8ae0d4b489491f/contracts/OptionsFactory.sol#L48

There seems to be an inconsistency with the comment here and wanted to make sure that it's not an issue in other parts of the code (which I haven't reviewed yet) that calculate the exercise window.

If _windowSize is a UNIX time, then does it mean that the the window is actually: FROM [_windowSize] to [expiry]?

More likely, _windowSize is number of seconds from expiry...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant