We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This is a low priority issue but something you may want to fix at some point.
There should be consistency when looking for the existence of a supported asset and returning the value for that supported asset.
The code below does an explicit check to see if "ETH" is a supported asset:
https://github.com/aparnakr/OptionsProtocol/blob/9363067b23278cd6d919cc0dad8ae0d4b489491f/contracts/OptionsFactory.sol#L154
However in the below code, it's assume that the lack of existence in the token[] is the value for the "ETH" token.
https://github.com/aparnakr/OptionsProtocol/blob/9363067b23278cd6d919cc0dad8ae0d4b489491f/contracts/OptionsFactory.sol#L75
This would be an issue in situations as follows:
In both of the above situations, the rest of the system will break down since isETH() is expected to be ERC20(0).
The text was updated successfully, but these errors were encountered:
No branches or pull requests
This is a low priority issue but something you may want to fix at some point.
There should be consistency when looking for the existence of a supported asset and returning the value for that supported asset.
The code below does an explicit check to see if "ETH" is a supported asset:
https://github.com/aparnakr/OptionsProtocol/blob/9363067b23278cd6d919cc0dad8ae0d4b489491f/contracts/OptionsFactory.sol#L154
However in the below code, it's assume that the lack of existence in the token[] is the value for the "ETH" token.
https://github.com/aparnakr/OptionsProtocol/blob/9363067b23278cd6d919cc0dad8ae0d4b489491f/contracts/OptionsFactory.sol#L75
This would be an issue in situations as follows:
In both of the above situations, the rest of the system will break down since isETH() is expected to be ERC20(0).
The text was updated successfully, but these errors were encountered: