Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mismatch between the amount on tx finished card and actual long amount closed #286

Open
yichiehliu opened this issue Apr 4, 2022 · 0 comments
Open

Mismatch between the amount on tx finished card and actual long amount closed #286

yichiehliu opened this issue Apr 4, 2022 · 0 comments
Labels
2 star bug Something isn't working frontend test trade page

Comments

@yichiehliu
Copy link
Contributor

yichiehliu commented Apr 4, 2022 •
edited
Loading

Describe the bug
There is a mismatch between the amount on tx finished card and actual long amount closed, causing test to fail, but couldn't reproduce it on manual test, the one fixing this issue need to run e2e test at line 592, which is a skipped test now"

The actual closed amount was 3.072147 ish oSQTH, but the card showed 10.597165 oSQTH

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
image

Additional context
Add any other context about the problem here.
yichiehliu added a commit that referenced this issue Apr 4, 2022
@yichiehliu
test: skipped test for issue #286
e18bca5
yichiehliu added a commit that referenced this issue Apr 12, 2022
@yichiehliu
Fe/e2e trade tests (#255)
fac7db5 
* test: add cypress.json

* config: update .gitignore, yarn.lock, packaga.json

config

* test: add component ids

* test: add crab ids

* test: add trade ids

* test: add cypress folder and settings

* test: add basic testing components

* test: add trade long&short tests

* test: add vault test

* test: add mint&buy tests

* test: add manual short test

* test: add strategy test

* test: add position test

* test: add metamask tests in case CI is not working

* test: add pages ids

* config: add CI setting yml

* test: update package json and basic components

* tests: add back lp test

* test: update lp ids

* test: add ci yml file

* test: remove unused ci file

* test: update lp on uniswap

* test: add lp nft as collateral tests

* test: update lp nft ids

* test: update long id

* test: update test number

* test: update decimal checks

* tests: update decimals input

* test: update ids

* udpate: short trade ids and before test condition to vault page

* test: update decimals condition

* testL update decimals

* test: check if open long card is opened by default

* test: check if input is zero before clicking max btn

* tests: update ids

* test: update scroll behavior on trade card and settings

* test: update decimals check

* test: removed redundant open short btn

* test: update no short osqth balance check

* test: add realized PnL & unrealized PnL tests

* test: split big tests into small chunks for short test

* test: comment Ci for now

* fix: add open long btn disabled conditions

* test: break big tests into small tests and add skip for long

* test: skipped test for issue #286

* test: update ids

* test: add approximate comparison

* test: update ids

* test: update vault tests and added skips for tests fail

* test: add loading time to wait for position update

* test: update link

* test: update ids

* test: skip lp vault & position tests

* test: add permission to spend method

* test: remove approximate eq

test: update lp ids

s

* test: add approve method for position and manual short

* test: split test into smaller PRs

* test: updated wait time and CR

* test: update wait time

* test: add approximate equal for long

* test: removed yml

* test: remove projectId

* doc: add test readme file

* test: updated decimals

* test: updated decimals

* test: update decimals
@KMKoushik KMKoushik added bug Something isn't working 1 star 2 star and removed 1 star labels Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2 star bug Something isn't working frontend test trade page
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@KMKoushik @yichiehliu