test: use defaults.ini instead of test environment

Signed-off-by: Carl Flottmann <[email protected]>

Author: art1f1c3R

tests/malware_analyzer/pypi/test_fake_email.py

@@ -4,27 +4,42 @@
 """Tests for the FakeEmailAnalyzer heuristic."""
 
 
-from unittest.mock import MagicMock, patch
+import os
+from pathlib import Path
+from unittest.mock import MagicMock
 
 import pytest
 
+from macaron.config.defaults import load_defaults
 from macaron.errors import HeuristicAnalyzerValueError
 from macaron.malware_analyzer.pypi_heuristics.heuristics import HeuristicResult
 from macaron.malware_analyzer.pypi_heuristics.metadata.fake_email import FakeEmailAnalyzer
 
-# Note: throughout these unit tests we set email_validator.TEST_ENVIRONMENT to True. This sets a global
-# environment variable in email_validator that ensures that all calls to validate_email have
-# test_environment=True set. This allows test and **.test domains and disables DNS deliverability checks
-# (so disables check_deliverability=true). See https://github.com/JoshData/python-email-validator for more.
-
 
 @pytest.fixture(name="analyzer")
 def analyzer_() -> FakeEmailAnalyzer:
     """Pytest fixture to create a FakeEmailAnalyzer instance."""
     return FakeEmailAnalyzer()
 
 
-@patch("email_validator.TEST_ENVIRONMENT", True)
+@pytest.fixture(name="fake_email_defaults_override")
+def set_defaults_(tmp_path: Path) -> None:
+    """Disable check_deliverability in defaults.ini so we do not make network connections.
+
+    Parameters
+    ----------
+    tmp_path: Path
+        Pytest temporary path fixture.
+    """
+    defaults_file = Path(os.path.join(tmp_path, "config.ini"))
+    content = """
+    [heuristic.pypi]
+    check_deliverability = False
+    """
+    defaults_file.write_text(content, encoding="utf-8")
+    assert load_defaults(str(defaults_file)) is True
+
+
 def test_missing_info(pypi_package_json: MagicMock, analyzer: FakeEmailAnalyzer) -> None:
     """Test when JSON 'info' key is missing in the PyPI data (should error).
 
@@ -40,7 +55,6 @@ def test_missing_info(pypi_package_json: MagicMock, analyzer: FakeEmailAnalyzer)
         analyzer.analyze(pypi_package_json)
 
 
-@patch("email_validator.TEST_ENVIRONMENT", True)
 def test_no_emails_present(pypi_package_json: MagicMock, analyzer: FakeEmailAnalyzer) -> None:
     """Test when no author_email or maintainer_email is present (should skip).
 
@@ -56,7 +70,6 @@ def test_no_emails_present(pypi_package_json: MagicMock, analyzer: FakeEmailAnal
     assert result == HeuristicResult.SKIP
 
 
-@patch("email_validator.TEST_ENVIRONMENT", True)
 def test_non_email(pypi_package_json: MagicMock, analyzer: FakeEmailAnalyzer) -> None:
     """Test with a non-parsable email address (should fail).
 
@@ -78,7 +91,6 @@ def test_non_email(pypi_package_json: MagicMock, analyzer: FakeEmailAnalyzer) ->
     assert "also not an email" in info["non_emails"]
 
 
-@patch("email_validator.TEST_ENVIRONMENT", True)
 def test_valid_email(pypi_package_json: MagicMock, analyzer: FakeEmailAnalyzer) -> None:
     """Test with valid email address format (should pass).
 
@@ -90,16 +102,19 @@ def test_valid_email(pypi_package_json: MagicMock, analyzer: FakeEmailAnalyzer)
         An initialized FakeEmailAnalyzer instance.
     """
     pypi_package_json.package_json = {
-        "info": {"author_email": "[email protected]", "maintainer_email": "[email protected]"}
+        "info": {
+            "author_email": "[email protected]",
+            "maintainer_email": "[email protected]",
+        }
     }
     result, info = analyzer.analyze(pypi_package_json)
     assert result == HeuristicResult.PASS
 
     # assert types (for mypy)
     assert isinstance(info["valid_emails"], list)
 
-    assert "[email protected]" in info["valid_emails"]
-    assert "[email protected]" in info["valid_emails"]
+    assert "[email protected]" in info["valid_emails"]
+    assert "[email protected]" in info["valid_emails"]
 
 
 def test_get_emails(analyzer: FakeEmailAnalyzer) -> None: