Eliminate warnings from static analysis tool.

Author: anthony-tuininga

src/dpiError.c

@@ -161,7 +161,8 @@ int dpiError__getInfo(dpiError *error, dpiErrorInfo *info)
             info->sqlState = "01002";
             break;
         default:
-            if (error->buffer->code == 0 && error->buffer->errorNum == 0)
+            if (error->buffer->code == 0 &&
+                    error->buffer->errorNum == (dpiErrorNum) 0)
                 info->sqlState = "00000";
             else info->sqlState = "HY000";
             break;

src/dpiSodaColl.c

@@ -228,7 +228,7 @@ void dpiSodaColl__free(dpiSodaColl *coll, dpiError *error)
 // dpiSodaColl__getDocCount() [INTERNAL]
 //   Internal method for getting document count.
 //-----------------------------------------------------------------------------
-int dpiSodaColl__getDocCount(dpiSodaColl *coll,
+static int dpiSodaColl__getDocCount(dpiSodaColl *coll,
         const dpiSodaOperOptions *options, uint32_t flags, uint64_t *count,
         dpiError *error)
 {

src/dpiSodaDb.c

@@ -37,7 +37,7 @@ static int dpiSodaDb__checkConnected(dpiSodaDb *db, const char *fnName,
 // The provided cursor handle is iterated until either the limit is reached
 // or there are no more collections to find.
 //-----------------------------------------------------------------------------
-int dpiSodaDb__getCollectionNames(dpiSodaDb *db, void *cursorHandle,
+static int dpiSodaDb__getCollectionNames(dpiSodaDb *db, void *cursorHandle,
         uint32_t limit, dpiSodaCollNames *names, char **namesBuffer,
         dpiError *error)
 {

src/dpiUtils.c

@@ -149,11 +149,12 @@ int dpiUtils__parseNumberString(const char *value, uint32_t valueLength,
         uint8_t *numDigits, uint8_t *digits, dpiError *error)
 {
     char convertedValue[DPI_NUMBER_AS_TEXT_CHARS], exponentDigits[4];
-    int exponentIsNegative, exponent;
     uint8_t numExponentDigits, digit;
     uint32_t convertedValueLength;
     uint16_t *utf16chars, i;
+    int exponentIsNegative;
     const char *endValue;
+    int16_t exponent;
 
     // empty strings are not valid numbers
     if (valueLength == 0)
@@ -250,7 +251,7 @@ int dpiUtils__parseNumberString(const char *value, uint32_t valueLength,
             return dpiError__set(error, "no digits in exponent",
                     DPI_ERR_INVALID_NUMBER);
         exponentDigits[numExponentDigits] = '\0';
-        exponent = (int) strtol(exponentDigits, NULL, 0);
+        exponent = (int16_t) strtol(exponentDigits, NULL, 0);
         if (exponentIsNegative)
             exponent = -exponent;
         *decimalPointIndex += exponent;