-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace deis references in annotations #4
Comments
Any suggestions on the new annotation keys? /cc @SteveLasker |
How about |
They are used for compressed directories. If we adopt oras-project/oras#178, then we don't need to bother those annotations. |
Of course, I'd like to see #178, but I wouldn't block and seems you can use |
Is there a risk to users if these annotations are changed? As in, will Helm and other applications using oras be able to unpack charts using these annotations? I'm okay with changing the annotation, but if it breaks something I'd like to know so we can inform users of breaking changes to |
@bacongobbler Helm's use of oras-go (both the old version and the one in the HIP 6 PR) does not do anything with these annotations, so we are safe here |
I think we can add the website domain name as an option in annotations, then we have two options:
How about we vote one and then provide a backward compact solution? @SteveLasker @bacongobbler @shizhMSFT @sajayantony @yizha1 |
See https://github.com/oras-project/oras-go/search?q=deis
cc @shizhMSFT
The text was updated successfully, but these errors were encountered: