Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deis references in annotations #4

Open
jdolitsky opened this issue Jun 2, 2021 · 7 comments
Open

Replace deis references in annotations #4

jdolitsky opened this issue Jun 2, 2021 · 7 comments
Milestone

Comments

@jdolitsky
Copy link
Contributor

See https://github.com/oras-project/oras-go/search?q=deis

cc @shizhMSFT

@shizhMSFT
Copy link
Contributor

Any suggestions on the new annotation keys? /cc @SteveLasker

@SteveLasker
Copy link
Contributor

How about cncf.oras.*
What are these used for?

@shizhMSFT
Copy link
Contributor

shizhMSFT commented Jun 7, 2021

They are used for compressed directories. If we adopt oras-project/oras#178, then we don't need to bother those annotations.

@SteveLasker
Copy link
Contributor

Of course, I'd like to see #178, but I wouldn't block and seems you can use cncf.oras, however that does presume the project is accepted, so I'd suggest holding this annotation for now. It also makes it interesting how these would work if a new client is looking for cncf.oras and it discovers deis.oras?
Are you thinking of maintaining some backwards compat?

@bacongobbler
Copy link

bacongobbler commented Aug 5, 2021

Is there a risk to users if these annotations are changed? As in, will Helm and other applications using oras be able to unpack charts using these annotations?

I'm okay with changing the annotation, but if it breaks something I'd like to know so we can inform users of breaking changes to helm chart push/helm chart pull in the next update.

@jdolitsky
Copy link
Contributor Author

@bacongobbler Helm's use of oras-go (both the old version and the one in the HIP 6 PR) does not do anything with these annotations, so we are safe here

@shizhMSFT shizhMSFT added this to the future milestone May 16, 2022
@FeynmanZhou
Copy link
Member

I think we can add the website domain name as an option in annotations, then we have two options:

  • cncf.oras
  • land.oras

How about we vote one and then provide a backward compact solution? @SteveLasker @bacongobbler @shizhMSFT @sajayantony @yizha1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: No status
Development

No branches or pull requests

5 participants