Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor OnCompleted() of metadata handlers #1573

Closed
wangxiaoxuan273 opened this issue Dec 9, 2024 · 0 comments · Fixed by #1583 · May be fixed by #1587
Closed

Refactor OnCompleted() of metadata handlers #1573

wangxiaoxuan273 opened this issue Dec 9, 2024 · 0 comments · Fixed by #1583 · May be fixed by #1587

Comments

@wangxiaoxuan273
Copy link
Contributor

wangxiaoxuan273 commented Dec 9, 2024 •
edited
Loading

OnCompleted should have no parameters as it only renders metadata output. We also need to make it an independent interface and make metadata handlers contain it.

The OnCompleted() function will be renamed as Render().

Affected command:

  • oras attach
  • oras pull
  • oras push
  • oras manifest index
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@wangxiaoxuan273