New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

example_18-01_from_disk readFilenames problem #85

Open

j32u4ukh opened this issue Jan 23, 2021 · 0 comments

j32u4ukh commented Jan 23, 2021

The code of readFilenames for windows users has two problem as below:

When dealing with the situation no files found, will cause no return value problem.

...
if ((dir = FindFirstFile((directory + "/*").c_str(), &file_data)) == INVALID_HANDLE_VALUE)
        return;  // no files found
    do {
...

Add full_file_name into vector of filenames, cause the program can not find files.

    ...
        filenames.push_back(full_file_name);
    } while (FindNextFile(dir, &file_data));
    ....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment