Light Protanopia & Deuteranopia colorblind theme makes PR status confusing

[dgattey]

Select Topic Area

Product Feedback

GitHub Feature Area

UI/UX

Body

The Protanopia & Deuteranopia colorblind themes appear to have changed recently from their ~orange color to a ~red color, in ways that hurt usability. It's hard to tell at a glance that this PR is open and not erroring in some way, thanks to the red = problem association Github has + most products have in non-colorblind mode.
vs

I much preferred the lighter orange color before for easily distinguishing status and color. Was it not distinct enough from the ~blue that was being used against it? This also makes Light Tritanopia not be much different.

Dark mode looks better, but still too reddish compared to the older colors

Proto/Deuter	Trit

[github-actions[bot]]

💬 Your Product Feedback Has Been Submitted 🎉

Thank you for taking the time to share your insights with us! Your feedback is invaluable as we build a better GitHub experience for all our users.

Here's what you can expect moving forward ⏩

• Your input will be carefully reviewed and cataloged by members of our product teams. 
  • Due to the high volume of submissions, we may not always be able to provide individual responses.
  • Rest assured, your feedback will help chart our course for product improvements.
• Other users may engage with your post, sharing their own perspectives or experiences. 
• GitHub staff may reach out for further clarification or insight. 
  • We may 'Answer' your discussion if there is a current solution, workaround, or roadmap/changelog post related to the feedback.

Where to look to see what's shipping 👀

• Read the Changelog for real-time updates on the latest GitHub features, enhancements, and calls for feedback.
• Explore our Product Roadmap, which details upcoming major releases and initiatives.

What you can do in the meantime 💻

• Upvote and comment on other user feedback Discussions that resonate with you.
• Add more information at any point! Useful details include: use cases, relevant labels, desired outcomes, and any accompanying screenshots.

As a member of the GitHub community, your participation is essential. While we can't promise that every suggestion will be implemented, we want to emphasize that your feedback is instrumental in guiding our decisions and priorities.

Thank you once again for your contribution to making GitHub even better! We're grateful for your ongoing support and collaboration in shaping the future of our platform. ⭐

[cehfisher]

Thank you @dgattey for taking the time to share your feedback! This issue has been filed with the GitHub accessibility team. We will follow-up here with any updates or questions. Thanks again!

[tuchandra]

Hi @cehfisher - can you check with the accessibility team about recent changes here? The PR colors changed today and are now much harder for me to distinguish; see also another user's comment here.

[SanjayVas]

This suddenly got much worse. Now the Open and Merged colors look the same. I had to switch back to the regular Light theme.

[tuchandra]

I also had this happen today - it was extremely disorienting until I realized what was happening, and even that doesn't help me much because I cannot see the difference between those two colors without looking impractically close.

[michael-wei-syn]

Experiencing same issue as above recent comments where open and merged PR statuses are virtually identical in color when using dark proto/deuteranopia themes.
Observed today only; yesterday was fine.

[ShaneNY]

Same for me, yesterday was fine, today is bad, colors have changed

[Emilgardis]

Was going to open a new discussion but found this :D

Previously the colors on Dark Protanopia & Deuteranopia in the colorblind theme feature preview for closed and opened issues/pr were much easier to tell apart. Recently they were changed and it's basically impossible to tell by color alone now if the status is done or open.
I have deuteranopia for context.

The colors seem to be #58a6ff for open and #ab7df8 for done. Considering these colors have a contrast level of 1.18:1 I'm not sure why these colors were picked.

#6385 seems relevant

[mhuisi]

I agree. The colors are now virtually useless for me.

[cehfisher]

Hi all - thank you for letting us know about this issue! The Primer and accessibility engineering teams are looking into a solution, as it seems there was a recent change that impacted some of our themes. We hope to have more information / a fix for you soon!

[cehfisher]

Quick update - there is a PR that should be pushed later today to resolve this issue. Stay tuned for more information and thank you for your continued patience!

[cehfisher]

Hello all - when you can, please clear your cache and retest the colorblind themes. The fix for the reversion should be in place now!

[mhuisi]

Works for me. Thanks!

[snoyer]

it does look fixed, thanks!

[michael-wei-syn]

Appears fixed on the dark proto/deutera theme at least; thanks!!

[cehfisher]

Hi @dgattey - I’m wondering if the original issue you reported might not be fully addressed by these theme changes. Could you confirm if your issue is still relevant?