Github user wrongly assumed my code doesn't work and blocked me #146808
Replies: 3 comments
-
Hi - it looks like you made a contribution to an open source project, the code was untested, and the the contribution was declined. This is pretty standard; Open Source Projects won't merge untested code, and maintainers rarely have the time to test code for contributors. I'd recommend moving on rather than trying to continue to reach out the project maintainer. They've made it clear they don't want to engage. This guide talks some about expected behavior when contributing to open source: https://opensource.guide/how-to-contribute/ |
Beta Was this translation helpful? Give feedback.
-
But the code IS tested now and it works. It worked all along. Maintainers should also test code before merging either way. He also accepted a contribution from me before. |
Beta Was this translation helpful? Give feedback.
-
Hi @mruncreative, I could provide some insights from a maintainer's perspective. The human side of open source.
Mostly agree. Open source is more human though. That might be the perspective you're missing. When you push those boundaries, the maintainer is right to give their well-being more priority and stop engaging in the discussion. So, when you engage in open source, think about the maintainers' perspective too. |
Beta Was this translation helpful? Give feedback.
-
Select Topic Area
Question
Body
Github user wrongly assumed my code doesn't work, closed my PR and blocked me.
dessalines/thumb-key#1186
I can see that he doesn't like that I didn't test it on real hardware right away but it wasn't much different than adding a keyboard layout which is done in code too in his application.
I just wrote the code using logic and compiling snippets in an online compiler.
I've compiled and tested it and it works fine.
app-release.zip
There was no reason to throw a fit.
The problem is I can't tell him that I've compiled and tested it (Figuring out how to build it myself took indeed hours) because he doesn't provide any contact information aside from some Mastodon of which I'm not sure he's active on and his own clone of Mastodon on which he is the administrator and you can't even register without "applying for registration" which he then denies.
How do I get my code merged?
There is at least one other user who liked my previous addition.
dessalines/thumb-key#1181
Beta Was this translation helpful? Give feedback.
All reactions