Ask for removal of aria-labels in contribution stats

[yncat]

Select Topic Area

Bug

GitHub Feature Area

Profile

Body

I found a bug in the web UI where aria-labels were shadowing the inner text.

1. Go to someone's profile. Example: mine https://github.com/yncat
2. Look at the contribution stats markup
3. the collapsable buttons have aria-label="collapse" or "expand" respectively.
4. These aria-labels are prioritized by screen readers, which disables us to read inner text without special keystrokes.

   <summary role=​"button" data-target=​"details-toggle.summaryTarget" data-action=​"click:​details-toggle#toggle" data-aria-label-closed=​"Expand" data-aria-label-open=​"Collapse" aria-label=​"Collapse" aria-expanded=​"true" data-view-component=​"true" class=​"btn-link Link--muted no-underline lh-condensed width-full f4"> ​ </summary>

This markup shadows the inner summaryText.

Since collapsed / expanded status is already presented by aria-expanded, the outer aria-label is not necessary in my opinion.

[github-actions[bot]]

💬 Your Product Feedback Has Been Submitted 🎉

Thank you for taking the time to share your insights with us! Your feedback is invaluable as we build a better GitHub experience for all our users.

Here's what you can expect moving forward ⏩

• Your input will be carefully reviewed and cataloged by members of our product teams. 
  • Due to the high volume of submissions, we may not always be able to provide individual responses.
  • Rest assured, your feedback will help chart our course for product improvements.
• Other users may engage with your post, sharing their own perspectives or experiences. 
• GitHub staff may reach out for further clarification or insight. 
  • We may 'Answer' your discussion if there is a current solution, workaround, or roadmap/changelog post related to the feedback.

Where to look to see what's shipping 👀

• Read the Changelog for real-time updates on the latest GitHub features, enhancements, and calls for feedback.
• Explore our Product Roadmap, which details upcoming major releases and initiatives.

What you can do in the meantime 💻

• Upvote and comment on other user feedback Discussions that resonate with you.
• Add more information at any point! Useful details include: use cases, relevant labels, desired outcomes, and any accompanying screenshots.

As a member of the GitHub community, your participation is essential. While we can't promise that every suggestion will be implemented, we want to emphasize that your feedback is instrumental in guiding our decisions and priorities.

Thank you once again for your contribution to making GitHub even better! We're grateful for your ongoing support and collaboration in shaping the future of our platform. ⭐

[cehfisher]

Hello @yncat - thank you for providing this feedback! We have filed this with our Accessibility team so that it can be reviewed and will follow-up here with any additional questions or updates. Thanks again!

[cehfisher]

Hi @yncat - we recently made some accessibility updates to the contribution graph. Upon reviewing your issue again, the accessibility team noted that the summary output has changed to:

<summary role="button" data-target="details-toggle.summaryTarget" data-action="click:details-toggle#toggle" aria-expanded="true" data-view-component="true" class="btn-link Link--muted no-underline lh-condensed width-full f4">

In particular, the following attributes were removed to help improve the screen reader experience:
data-aria-label-closed="Expand" data-aria-label-open="Collapse" aria-label="Collapse"

When you have a chance, please re-test and let us know if your issue is resolved. Thanks!

[yncat]

Hi @cehfisher !
Sorry for my late reply. Just confirmed that it's now perfect to me! Thank you so much!