[@mantine/dates] Term column
is overloaded
#3927
filiptammergard
started this conversation in
Feedback
Replies: 2 comments 1 reply
-
I'll consider renaming it in v7, though it is too far away now |
Beta Was this translation helpful? Give feedback.
0 replies
-
Seems like v7 is on its way. Is this something you consider @rtivital? |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Hey!
Both when looking into documentation and when doing some code contributions, I noticed that the term
column
is overloaded when it comes to the date components which makes things a bit confusing at times.We have the props
columnsToScroll
andnumberOfColumns
in many date components. In this context,column
refers to the entire picker.On the other hand, in the keyboard interactions section, it says that ArrowDown focuses next year/month/date "in a column that is not disabled". In this context,
column
refers to the table grid column within a date picker.Attaching some diagrams of terminology used.
DatePicker:

MonthPicker:

YearPicker:

Hopefully that makes it clear what I mean by
column
being overloaded as a term. It's the same in code thatcolumn
in different places refer to different things.For me, it makes sense to reserve the term
column
for the semantic meaning in the context of a table grid, which makes it simple to use together with the termsrow
andcell
.I'd consider changing the term for the other meaning to
picker
, which would mean changing the prop names topickersToScroll
andnumberOfPickers
. I know this is a breaking change, so I'm mostly looking for discussion and see if this is something that could be planned for v7.What do you think?
Beta Was this translation helpful? Give feedback.
All reactions