Perl support for mfussenegger/nvim-lint

[oalders]

At this point, no Perl linters are supported by https://github.com/mfussenegger/nvim-lint

[WhoIsSethDaniel]

Adding them would be pretty simple. I haven't done it because perlcritic already runs via perlnavigator so I would never use it.

Beyond perlcritic what other linters are you thinking of?

[oalders]

Can perltidy do linting?

It can and I think a lot of people may not realize that. I believe the flags would be:

--assert-tidy --no-standard-output --outfile=/dev/null

[WhoIsSethDaniel]

I can only get perltidy to print the first error it encounters. That doesn't seem very useful so I was wondering if there is a way to get it to find and print all errors? I was unable to find anything in the perldoc. I am running this: perltidy --assert-tidy --standard-error-output --outfile=/dev/null

[oalders]

I don't actually know off-hand, but the maintainer of perltidy is lightning fast about responding to issues, so it would be worth bringing up there. If it's possible to do and undocumented, that would be a worthwhile change to the docs.

[WhoIsSethDaniel]

A discussion:
perltidy/perltidy#123

[oalders]

That did get answered very quickly!

[WhoIsSethDaniel]

Adding formatters to formatter.nvim is probably a good idea too. perltidy has a PR, but perlimports does not.

[oalders]

Excellent! I've added that PR to https://github.com/orgs/perl-ide/projects/1/views/1 so that we can track it there.

[WhoIsSethDaniel]

What about ale? Should we also add perltidy and periimports to it? https://github.com/dense-analysis/ale/tree/master/ale_linters/perl

[oalders]

Yes, I think it's still fairly popular. I may have perlimports in a branch. I will check.

[oalders]

I think this works: dense-analysis/ale@master...oalders:ale:perlimports

[WhoIsSethDaniel]

Are you planning on submitting that as a PR?

[oalders]

Yes, I will do that. I still use Ale in a few places anyway.

[WhoIsSethDaniel]

There's also neoformat of which I have very little familiarity, but it gets mentioned a fair amount on-line.

[oalders]

That looks good too. Already has perltidy, but needs the others.

[WhoIsSethDaniel]

I can look at everything that isn't ALE.

[oalders]

Excellent. Thank you!

[WhoIsSethDaniel]

There's also https://github.com/iamcco/diagnostic-languageserver . I mention this because there is this: https://github.com/creativenull/diagnosticls-configs-nvim.

[oalders]

Neat. Yes, I guess we should consider that as well.

[WhoIsSethDaniel]

There's an issue with perlimports and nvim-lint. nvim-lint expects a linter to either take a file argument, or read from stdin, but it does not expect (or support) that it will require both.

[WhoIsSethDaniel]

I think I can work around it. I'm not certain it's 100% correct.

[oalders]

Yeah, that's unfortunate. perlimports could probably be rigged not to require the filename if it's an issue. I wasn't really thinking of editors when I was originally writing it.

[WhoIsSethDaniel]

nvim-lint PRs:
perlimports: mfussenegger/nvim-lint#347
perlcritic: mfussenegger/nvim-lint#346

[WhoIsSethDaniel]

formatter.nvim PRs:
perlimports: mhartington/formatter.nvim#273

[WhoIsSethDaniel]

neoformat:
perlimports: sbdchd/neoformat#473

[oalders]

These all look great. Did you have a look at the line range arguments that can be used as well? https://metacpan.org/pod/perlimports#-range-begin

Not sure if any of those are applicable here?

[oalders]

I added all of the PRs to the project board.

[WhoIsSethDaniel]

another target: https://github.com/creativenull/efmls-configs-nvim

[WhoIsSethDaniel]

diagnosticls configs for perl formatters: creativenull/diagnosticls-configs-nvim#35

[WhoIsSethDaniel]

efm configs for perl formatters: creativenull/efmls-configs-nvim#58

[oalders]

Looks like there is also https://github.com/stevearc/conform.nvim#formatters

[WhoIsSethDaniel]

That's a good find. It's also one I'm going to have to try. It's written by stevearc who does good stuff. It also seems like it should co-exist well with LSP formatting (vim.lsp.buf.format() etc...)

[WhoIsSethDaniel]

I submitted PRs for perltidy and perlimports. They have been accepted.

[WhoIsSethDaniel]

I've added perlcritic to efm and diagnosticls configs (for neovim):

• feat: add perlcritic linter creativenull/diagnosticls-configs-nvim#37
• feat: add perlcritic linter creativenull/efmls-configs-nvim#71