From fcde9c6efeab7c95c01b3be24e6dbda254ac40f3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marek=20Barto=C5=A1?= Date: Sat, 6 May 2023 21:35:00 +0200 Subject: [PATCH] Options: setFillRawValues() -> setTrackRawValues() --- src/Processing/DefaultProcessor.php | 5 +---- src/Processing/Options.php | 16 +++++----------- tests/Unit/Processing/DefaultProcessorTest.php | 4 ++-- 3 files changed, 8 insertions(+), 17 deletions(-) diff --git a/src/Processing/DefaultProcessor.php b/src/Processing/DefaultProcessor.php index 875309a0..c95791a1 100644 --- a/src/Processing/DefaultProcessor.php +++ b/src/Processing/DefaultProcessor.php @@ -619,7 +619,7 @@ private function fillObject( $meta = $callContext->getMeta(); // Set raw data - if ($options->isFillRawValues()) { + if ($options->isTrackRawValues()) { $this->rawValuesMap->setRawValues($object, $rawData); } @@ -657,9 +657,6 @@ private function createHolder(string $class, ClassRuntimeMeta $meta, ?MappedObje return new ObjectHolder($this->objectCreator, $meta, $class, $object); } - /** - * @return mixed - */ public function getRawValues(MappedObject $object) { return $this->rawValuesMap->getRawValues($object); diff --git a/src/Processing/Options.php b/src/Processing/Options.php index efe07af9..1e3e93f6 100644 --- a/src/Processing/Options.php +++ b/src/Processing/Options.php @@ -17,7 +17,7 @@ final class Options private bool $prefillDefaultValues = false; - private bool $fillRawValues = false; + private bool $trackRawValues = false; /** @var array */ private array $dynamicContexts = []; @@ -68,20 +68,14 @@ public function isPrefillDefaultValues(): bool return $this->prefillDefaultValues; } - /** - * Make user-sent values accessible by $mappedObject->getRawValues() - * Used only if objects are initialized - * Use only for debug, it may lead to significant raw data grow in bigger hierarchies - * you can set data to a custom property in before class callback, if are always needed - */ - public function setFillRawValues(bool $fill = true): void + public function setTrackRawValues(bool $fill = true): void { - $this->fillRawValues = $fill; + $this->trackRawValues = $fill; } - public function isFillRawValues(): bool + public function isTrackRawValues(): bool { - return $this->fillRawValues; + return $this->trackRawValues; } public function addDynamicContext(object $context): void diff --git a/tests/Unit/Processing/DefaultProcessorTest.php b/tests/Unit/Processing/DefaultProcessorTest.php index e51e8664..f9723278 100644 --- a/tests/Unit/Processing/DefaultProcessorTest.php +++ b/tests/Unit/Processing/DefaultProcessorTest.php @@ -455,7 +455,7 @@ public function testInitialization(): void public function testTransformation(): void { $options = new Options(); - $options->setFillRawValues(); + $options->setTrackRawValues(); $data = [ 'bool' => 'true', @@ -697,7 +697,7 @@ public function testPropertyCallbacksFailure(): void public function testBeforeClassCallbackMixedValue(): void { $options = new Options(); - $options->setFillRawValues(); + $options->setTrackRawValues(); $vo = null; $exception = null;