Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path_RoundedComposite::Clone() doesn't copy F_base_start and F_base_via #445

Open
DobbyPeng opened this issue Aug 17, 2023 · 2 comments
Open

Comments

@DobbyPeng
Copy link

DobbyPeng commented Aug 17, 2023

I'm trying to use Path_RoundedComposite::Clone() to clone a Path_RoundedComposite object.
But I found that Path_RoundedComposite::Clone() doesn't clone F_base_start and F_base_via.
If I call Path_RoundedComposite::Finish() on the clone, it doesn't know the last pose.

Path* Path_RoundedComposite::Clone() {
return new Path_RoundedComposite(static_cast<Path_Composite*>(comp->Clone()),radius,eqradius,orient->Clone(), true, nrofpoints);
}

@MatthijsBurgh
Copy link
Collaborator

According to the constructor:

Path_RoundedComposite::Path_RoundedComposite(Path_Composite* _comp,
double _radius, double _eqradius, RotationalInterpolation* _orient,
bool _aggregate,int _nrofpoints):
comp(_comp), radius(_radius), eqradius(_eqradius), orient(_orient), nrofpoints(_nrofpoints), aggregate(_aggregate) {
}

Everything is taken into account correctly. So the problem is somewhere else.

The variables F_base_start and F_base_via are marked as cache in the header. But I am not really sure that is correct.

But this code is really old and I don't have a clue about what is and should be doing. So please make your case why things need to change in a PR.

@DobbyPeng
Copy link
Author

In my case, I want to create a composite path of serval target poses. And in progress, I want to check if poses in the path can be reached by the robot.

So, I want to clone a path and call the Finish() on the clone. Then get every 1 mm(just for example) of pose for inspection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants