Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Allow the use of :host in variable definitions #32

Closed
fabiiomiiguel opened this issue May 23, 2024 · 1 comment
Closed

[Feature] Allow the use of :host in variable definitions #32

fabiiomiiguel opened this issue May 23, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@fabiiomiiguel
Copy link
Contributor

fabiiomiiguel commented May 23, 2024 •
edited
Loading

I'm currently using web components with Vue 3, oruga-ui and theme-oruga.

With the release 3.0.0 the variables stop working correctly because the web components rely on shadow-dom, which doesn't use the :root selector.

I created a pull request to allow the usage of :host for web components.

This code was based on this pull request from bootstrap.

What do you think?
@fabiiomiiguel fabiiomiiguel mentioned this issue May 23, 2024
Merged
@mlmoravek mlmoravek added the enhancement New feature or request label May 24, 2024
@mlmoravek
Copy link
Member

Nice! Thanks for the improvement :) Will be released soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mlmoravek @fabiiomiiguel