refactor: refactoring example to using Kratos SelfService UI Node Docker image #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jorgagu
force-pushed
the
refactor/kratos-hydra-example
branch
from
8b51430
to
b5442eb
Compare
Jorgagu
force-pushed
the
refactor/kratos-hydra-example
branch
from
b5442eb
to
170cd5f
Compare
…elfService UI Node Docker image
Jorgagu
force-pushed
the
refactor/kratos-hydra-example
branch
from
170cd5f
to
472575e
Compare
|
Hey @Jorgagu |
|
👋 @vinckr any update or review on this PR ? |
vinckr
approved these changes
Aug 10, 2023
There was a problem hiding this comment.
This looks great, thanks so much @Jorgagu 🙌
I ran the example and everything worked as expected, also many thanks for the clean up.
This is an excellent basis for Hydra+Kratos integration and will see to promote it a bit more in the coming weeks.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue or Design Document
Refactoring example now Kratos SelfService UI Node is updated with the implementation of Hydra Consent screen.
PR of Kratos SeftService UI Node containing the code used previously in the example: ory/kratos-selfservice-ui-node#257
Checklist
If this pull request addresses a security vulnerability,
I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
Further comments