Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Sign In With Google and Apple #84

Merged
merged 44 commits into from
Nov 3, 2023

Conversation

sashatalalasha
Copy link
Contributor

This pull request adds sign in with Google and sign in with Apple to Flutter app.

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

* feat: get current session information

* feat: create login flow

* feat: login with email and password

* feat: register with email and password

* fix: handle all errors incl deserialization error

* feat: logout & get session on home page init

* feat: show session information

* feat: add design and refactor blocs

* fix: change package and folder name

* fix: change package name

* docs: update README.md

* refactor: delete unused icon

* refactor: remove unused packages

* chore: format code

* refactor: add missing package and delete unused test

* chore: display components dynamically

* chore: clean up and format code

* fix: aal2 navigation

* chore: remove unnecessary code

* chore: fix typo and rename variables

* chore: separate exception handlings

* fix: prevent null exception
@sashatalalasha sashatalalasha changed the title Feat: Sign In With Google and Apple feat: Sign In With Google and Apple Oct 25, 2023
Copy link
Member

@jonas-jonas jonas-jonas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very, very cool 🚀.

jonas-jonas
jonas-jonas previously approved these changes Nov 3, 2023
Copy link
Member

@jonas-jonas jonas-jonas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks super nice! Thank you 🚀

flutter-ory-network/README.md Outdated Show resolved Hide resolved
flutter-ory-network/lib/repositories/auth.dart Outdated Show resolved Hide resolved
@vinckr vinckr merged commit ea68946 into ory:master Nov 3, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants