chore: compile a static binary in Docker #3826
Merged
+18
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ic-debian12 to distroless/base-nossl-debian12 to get fewer CVE alerts Uses the technique described in https://www.arp242.net/static-go.html
|
Does SQLite with JSON still work correctly if this patch is applied? |
I believe so. The Wanted to get a CI run through first of all, and see if I can find any regressions. |
This is no longer necessary since SQLite 3.38, and was in fact removed completely in go-sqlite v1.14.13
|
This commit deleted all build tags associated with JSON. The first released version with that change is 1.14.13. We should be good. |
|
Oh, that's great! |
|
The best way to test for regression is to probably execute the quickstart using the updated image |
|
Image works! Tested a couple of things, including QuickStart |
aeneasr
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move to distroless/static-debian12 from distroless/base-nossl-debian12 to get fewer CVE alerts
Uses the technique described in https://www.arp242.net/static-go.html