-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rate control #12
Comments
Hi @boxerab Thanks for bringing a good point. |
Thanks, @osamu620 . Looking forward to the visual weighting feature. |
For the future plan for the rate control in the HT block encoding, I think this issue should remain. |
Hello @osamu620, I am interested in working on a rate control algorithm for HTJ2K. Do you know of any papers that may be relevant ? Apparently the only existing non-iterative precise rate control algorithm at the moment is inside Kakadu library. |
@boxerab
Yes. But Kakadu's rate-control algorithm is patent-protected, I think. |
No worries, thanks for your reply.
that makes sense
what about magref and sigprop passes - wouldn't you need those passes as well? |
I would say the generation of HT MagRef and HT SigProp is not mandatory. I think generating multiple HT Cleanup passes is critical for the throughput of HTJ2K encoding pipeline. |
Thanks - is it difficult to run multiple HT cleanup passes with the current state of the codec ? |
@boxerab |
I completely agree. Let me know if I can help with optimization. It wouldn't be too hard to add a thread pool to the block coding logic |
I'm not familiar with thread pool implementations, so your help would be highly appreciated. One additional thing: |
@osamu620 sorry for the delay - I will create a PR with a thread pool for the block coder. The implementation I currently use Improving memory allocation will certainly improve performance, but I think we get the biggest increase from thread pool and SIMD. |
@boxerab |
I am here to put in my 2 cents.
Kakadu having a patent on the method does not exclude you from using it. I, and I can NOT talk for Kakadu, think that you should be fine if you used it in your open source JPEG2000 library. In the past, Kakadu has been generous to other parties using its patents; for example, the HT algorithm is available free of charge, even though it is patented. In any case, you can contact Prof. David Taubman directly regarding this matter. Osamu and I can suggest ways of doing this. Cheers, |
@aous72 |
@aous72 thanks very much for your comments. I hope there are many good solutions to the HTJ2K rate control issue. |
Hello!
Very glad to see another HTJ2K project getting started.
Do you plan on implementing rate control or new Q factor for HTJ2K ?
Many thanks,
Aaron
The text was updated successfully, but these errors were encountered: