go.mod: update osbuild/images to v0.128.0 #864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is going to need changes in the test scripts that rely on the fstab stage to verify mountpoints. |
Tests should be passing now. |
mvo5
previously approved these changes
Mar 27, 2025
test/test_manifest.py
Outdated
| @@ -9,7 +9,8 @@ | |||
| import pytest | |||
|
|
|||
| import testutil | |||
| from containerbuild import build_container_fixture # pylint: disable=unused-import | |||
| from containerbuild import \ | |||
There was a problem hiding this comment.
(just curious) why split this line? I really don't mind, is it for aesthetics or some editor defaults?
There was a problem hiding this comment.
oops. That was isort. I keep it on but I need to be careful when it changes things I'm not modifying.
|
|
achilleas-k
force-pushed
the
update-images/mount-units
branch
from
1d5128c to
421ebe7
Compare
|
Requires osbuild/images#1366 |
achilleas-k
force-pushed
the
update-images/mount-units
branch
from
421ebe7 to
6b3d7f6
Compare
achilleas-k
changed the title
A major part of this update is the ability to use mount units instead of defining mountpoints in /etc/fstab. For bootc disk images, this is always enabled [1] and requires no further configuration. Closes osbuild#756 [1] osbuild/images@43f1a32
We need to import the fixtures and use them indirectly, which makes it appear like an unused import. Instead of disabling the linter on the line, let's suppress the warning by using _ as the import name. I find this nicer.
Some tests rely on reading the fstab options from the manifest to verify that filesystems and swap partitions generate the right options. These have been changed to instead look for org.osbuild.systemd.unit.create stages with filenames ending in .mount and .swap.
achilleas-k
force-pushed
the
update-images/mount-units
branch
from
6b3d7f6 to
f496784
Compare
supakeen
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A major part of this update is the ability to use mount units instead of defining mountpoints in /etc/fstab.
For bootc disk images, this is always enabled [1] and requires no further configuration.
Closes #756
[1] osbuild/images@43f1a32