Wizard: Disable registration by default (HMS-5437) #2832
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regexowl
force-pushed
the
disable-registration-by-default
branch
from
7dd84fc to
bb3ff66
Compare
|
/jira-epic HMS-5279 |
schutzbot
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #2832 +/- ##
==========================================
- Coverage 83.04% 83.03% -0.02%
==========================================
Files 200 200
Lines 22801 22800 -1
Branches 2255 2254 -1
==========================================
- Hits 18935 18931 -4
- Misses 3844 3847 +3
Partials 22 22
Continue to review full report in Codecov by Sentry.
|
|
@lucasgarfield rhsm issues were resolved meaning activation keys are available again. Response time is also quite fast (1.19s), we might not need to even merge this |
This changes the initial registration value from `register-now-rhc` to `register-later`, making the registration checkbox disabled by default.
regexowl
force-pushed
the
disable-registration-by-default
branch
2 times, most recently
from
fb66ac3 to
01099c9
Compare
regexowl
force-pushed
the
disable-registration-by-default
branch
from
01099c9 to
f5e8d0b
Compare
|
Closing this one, activation keys are working again and the queries are reasonably fast (around one second). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2826
This sets default registration value to
register-laterand adjusts the tests.JIRA: HMS-5437