Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packit.yaml: fix upstream tag template #2831

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

croissanne
Copy link
Member

Currently the version in fedora is v55, which is wrong, it should just be 55.

@croissanne croissanne requested a review from thozza February 3, 2025 13:15
Currently the version in fedora is `v55`, which is wrong, it should just
be `55`.
@regexowl regexowl force-pushed the fix-upstrema-tag-template branch from dd61d51 to 559b82c Compare February 3, 2025 13:19
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.95%. Comparing base (1b4ecdb) to head (559b82c).
Report is 1 commits behind head on main.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2831   +/-   ##
=======================================
  Coverage   82.95%   82.95%           
=======================================
  Files         199      199           
  Lines       22398    22398           
  Branches     2183     2183           
=======================================
  Hits        18581    18581           
  Misses       3795     3795           
  Partials       22       22           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b4ecdb...559b82c. Read the comment docs.

@regexowl regexowl merged commit 62a7721 into osbuild:main Feb 3, 2025
16 of 18 checks passed
@croissanne croissanne deleted the fix-upstrema-tag-template branch February 6, 2025 10:37
croissanne added a commit to croissanne/image-builder-frontend that referenced this pull request Feb 6, 2025
Downstream the "v" got dropped from the version by osbuild#2831, but then the
source url is wrong. The path has got a "v" in it, and the artefact
doesn't.

The workflow already got fixed in osbuild#2860.
croissanne added a commit that referenced this pull request Feb 6, 2025
Downstream the "v" got dropped from the version by #2831, but then the
source url is wrong. The path has got a "v" in it, and the artefact
doesn't.

The workflow already got fixed in #2860.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants