Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wizard: Remove CodeBlocks for "None" as a value (HMS-5454) #2846

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

regexowl
Copy link
Collaborator

@regexowl regexowl commented Feb 4, 2025

Fixes #2834

Render "None" just as a plain text when there are no values to be shown in the review expandable.

JIRA: HMS-5454

@regexowl regexowl added the 🍼 simple Simple and quick to review label Feb 4, 2025
@regexowl
Copy link
Collaborator Author

regexowl commented Feb 4, 2025

/jira-epic HMS-5294

@schutzbot schutzbot changed the title Wizard: Remove CodeBlocks for "None" as a value Wizard: Remove CodeBlocks for "None" as a value (HMS-5454) Feb 4, 2025
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.14%. Comparing base (e74675a) to head (e52fd91).
Report is 1 commits behind head on main.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2846   +/-   ##
=======================================
  Coverage   82.14%   82.14%           
=======================================
  Files         207      207           
  Lines       23181    23181           
  Branches     2274     2276    +2     
=======================================
  Hits        19042    19042           
  Misses       4112     4112           
  Partials       27       27           
Files with missing lines Coverage Δ
...teImageWizard/steps/Review/ReviewStepTextLists.tsx 95.54% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e74675a...e52fd91. Read the comment docs.

@regexowl regexowl force-pushed the fix-append-code-block branch 2 times, most recently from b9570ae to 45d7f10 Compare February 6, 2025 08:47
Render "None" just as a plain text when there are no values to be shown in the review expandable.
@regexowl regexowl force-pushed the fix-append-code-block branch from 45d7f10 to e52fd91 Compare February 7, 2025 09:38
Copy link
Collaborator

@mgold1234 mgold1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍼 simple Simple and quick to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A gray rectangle appears around the append value in Review step
2 participants