From 45fed14b4b0b3584c8467f12afb60b2f5e83a7d7 Mon Sep 17 00:00:00 2001 From: Lukas Zapletal Date: Tue, 19 Nov 2024 12:38:36 +0100 Subject: [PATCH] ostree: fix proxy parsing --- pkg/ostree/ostree.go | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/pkg/ostree/ostree.go b/pkg/ostree/ostree.go index 02f762056c..1b7cec0b65 100644 --- a/pkg/ostree/ostree.go +++ b/pkg/ostree/ostree.go @@ -6,6 +6,7 @@ import ( "encoding/hex" "fmt" "io" + "net" "net/http" "net/url" "os" @@ -158,7 +159,7 @@ func resolveRef(ss SourceSpec) (string, error) { if err != nil { return "", NewResolveRefError("error parsing ostree repository location: %v", err) } - u.Path = path.Join(u.Path, "refs/heads/", ss.Ref) + u.Path = path.Join(u.Path, "refs", "heads", ss.Ref) transport := http.DefaultTransport.(*http.Transport).Clone() if u.Scheme == "https" { @@ -190,7 +191,12 @@ func resolveRef(ss SourceSpec) (string, error) { } if ss.Proxy != "" { - proxyURL, err := url.Parse(ss.URL) + host, port, err := net.SplitHostPort(ss.Proxy) + if err != nil { + return "", NewResolveRefError("error parsing MTLS proxy URL '%s': %v", ss.URL, err) + } + + proxyURL, err := url.Parse("http://" + host + ":" + port) if err != nil { return "", NewResolveRefError("error parsing MTLS proxy URL '%s': %v", ss.URL, err) }