monitor: increase buffer to deal with very big messages #1200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit incrases the buffer os the osbuild message scanner to deal with very big messages. The default size of 64kb is too small for the `dracut` stage which will generate 5447 messages that /dev/log is not available and they come so rapidly that osbuild will pick them up in one big chunk. This is a short term fix, the deeper fix should be to tweak the osbuild monitor to have a smaller buffer size when sending stdout/stderr output from stages to the monitor. This will fix a crash in the bootc-image-builder anaconda builds that is currently breaking the integration test in konflux. See also osbuild/osbuild#1976
supakeen
approved these changes
Feb 7, 2025
achilleas-k
approved these changes
Feb 7, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
mvo5
added a commit
to mvo5/bootc-image-builder
that referenced
this pull request
Feb 7, 2025
This commit updates the images library to pull in the fix [0] for the overly long messages from osbuild. This should test the (previously) failing test that runs the centos-9 ISO with an attached terminal. [0] osbuild/images#1200
|
Wow, that must have been painful to debug... |
mvo5
added a commit
to mvo5/bootc-image-builder
that referenced
this pull request
Feb 8, 2025
This commit updates the images library to pull in the fix [0] for the overly long messages from osbuild. This should test the (previously) failing test that runs the centos-9 ISO with an attached terminal. [0] osbuild/images#1200
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit incrases the buffer os the osbuild message scanner to deal with very big messages. The default size of 64kb is too small for the
dracutstage which will generate 5447 messages that /dev/log is not available and they come so rapidly that osbuild will pick them up in one big chunk.This is a short term fix, the deeper fix should be to tweak the osbuild monitor to have a smaller buffer size when sending stdout/stderr output from stages to the monitor. This will fix a crash in the bootc-image-builder anaconda builds that is currently breaking the integration test in konflux.
See also osbuild/osbuild#1976