Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize the publish-pypi-package job #51

Open
3 tasks
gndrmnn opened this issue Sep 22, 2023 · 0 comments
Open
3 tasks

Finalize the publish-pypi-package job #51

gndrmnn opened this issue Sep 22, 2023 · 0 comments

Comments

@gndrmnn
Copy link
Contributor

gndrmnn commented Sep 22, 2023

We need to fix some small things in the publish-pypi-package job

  • Use $HOME/venv instead of /tmp/venv as venv directory by default
  • Make sure the upload-pypi upstream role has access to the variable containing the venv
  • Use var pypi_twine_executable: "/tmp/venv/bin/python -m twine" for upload-pypi. Of course do not hard-code the path instead use the venv variable. (this obviously only works once upload-pypi knows the venv var).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant