-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathparams_test.go
More file actions
401 lines (338 loc) · 10.7 KB
/
Copy pathparams_test.go
File metadata and controls
401 lines (338 loc) · 10.7 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
package electrodb
import (
"testing"
"github.com/aws/aws-sdk-go-v2/service/dynamodb/types"
)
func TestBuildGetItemParams(t *testing.T) {
schema := &Schema{
Service: "TestService",
Entity: "TestEntity",
Table: "TestTable",
Attributes: map[string]*AttributeDefinition{
"id": {Type: AttributeTypeString, Required: true},
"name": {Type: AttributeTypeString, Required: false},
},
Indexes: map[string]*IndexDefinition{
"primary": {
PK: FacetDefinition{Field: "pk", Facets: []string{"id"}},
SK: &FacetDefinition{Field: "sk", Facets: []string{"name"}},
},
},
}
entity, err := NewEntity(schema, nil)
if err != nil {
t.Fatalf("Failed to create entity: %v", err)
}
builder := NewParamsBuilder(entity)
keys := Keys{
"id": "test-123",
"name": "John Doe",
}
params, err := builder.BuildGetItemParams(keys, nil)
if err != nil {
t.Fatalf("Failed to build params: %v", err)
}
if params["TableName"] != "TestTable" {
t.Errorf("Expected TableName 'TestTable', got '%v'", params["TableName"])
}
keyMap, ok := params["Key"].(map[string]types.AttributeValue)
if !ok {
t.Fatal("Key is not a map")
}
pkVal, ok := keyMap["pk"].(*types.AttributeValueMemberS)
if !ok {
t.Fatal("PK is not a string value")
}
// Key values are lowercased for consistency (matching ElectroDB behavior)
if pkVal.Value != "$testservice#id_test-123" {
t.Errorf("Expected PK '$testservice#id_test-123', got '%s'", pkVal.Value)
}
skVal, ok := keyMap["sk"].(*types.AttributeValueMemberS)
if !ok {
t.Fatal("SK is not a string value")
}
// SK format: $<entity> + facet values (all lowercased)
if skVal.Value != "$testentity#name_john doe" {
t.Errorf("Expected SK '$testentity#name_john doe', got '%s'", skVal.Value)
}
}
func TestBuildPutItemParams(t *testing.T) {
schema := &Schema{
Service: "TestService",
Entity: "TestEntity",
Table: "TestTable",
Attributes: map[string]*AttributeDefinition{
"id": {Type: AttributeTypeString, Required: true},
"name": {Type: AttributeTypeString, Required: true},
"email": {Type: AttributeTypeString, Required: false},
"count": {
Type: AttributeTypeNumber,
Required: false,
Default: func() interface{} {
return 0
},
},
},
Indexes: map[string]*IndexDefinition{
"primary": {
PK: FacetDefinition{Field: "pk", Facets: []string{"id"}},
},
},
}
entity, err := NewEntity(schema, nil)
if err != nil {
t.Fatalf("Failed to create entity: %v", err)
}
builder := NewParamsBuilder(entity)
item := Item{
"id": "test-123",
"name": "John Doe",
"email": "john@example.com",
}
params, err := builder.BuildPutItemParams(item, nil)
if err != nil {
t.Fatalf("Failed to build params: %v", err)
}
if params["TableName"] != "TestTable" {
t.Errorf("Expected TableName 'TestTable', got '%v'", params["TableName"])
}
itemMap, ok := params["Item"].(map[string]types.AttributeValue)
if !ok {
t.Fatal("Item is not a map")
}
// Check that pk was added
if _, exists := itemMap["pk"]; !exists {
t.Error("Expected pk to be added to item")
}
// Check that default was applied
if _, exists := itemMap["count"]; !exists {
t.Error("Expected count default to be applied")
}
}
func TestBuildPutItemParamsMissingRequired(t *testing.T) {
schema := &Schema{
Service: "TestService",
Entity: "TestEntity",
Table: "TestTable",
Attributes: map[string]*AttributeDefinition{
"id": {Type: AttributeTypeString, Required: true},
"name": {Type: AttributeTypeString, Required: true},
},
Indexes: map[string]*IndexDefinition{
"primary": {
PK: FacetDefinition{Field: "pk", Facets: []string{"id"}},
},
},
}
entity, err := NewEntity(schema, nil)
if err != nil {
t.Fatalf("Failed to create entity: %v", err)
}
builder := NewParamsBuilder(entity)
item := Item{
"id": "test-123",
// name is missing but required
}
_, err = builder.BuildPutItemParams(item, nil)
if err == nil {
t.Fatal("Expected error for missing required attribute")
}
electroErr, ok := err.(*ElectroError)
if !ok {
t.Fatal("Expected ElectroError type")
}
if electroErr.Code != "MissingAttribute" {
t.Errorf("Expected error code 'MissingAttribute', got '%s'", electroErr.Code)
}
}
func TestBuildUpdateItemParams(t *testing.T) {
schema := &Schema{
Service: "TestService",
Entity: "TestEntity",
Table: "TestTable",
Attributes: map[string]*AttributeDefinition{
"id": {Type: AttributeTypeString, Required: true},
"name": {Type: AttributeTypeString, Required: false},
"count": {Type: AttributeTypeNumber, Required: false},
"tags": {Type: AttributeTypeList, Required: false},
},
Indexes: map[string]*IndexDefinition{
"primary": {
PK: FacetDefinition{Field: "pk", Facets: []string{"id"}},
},
},
}
entity, err := NewEntity(schema, nil)
if err != nil {
t.Fatalf("Failed to create entity: %v", err)
}
builder := NewParamsBuilder(entity)
keys := Keys{"id": "test-123"}
setOps := map[string]interface{}{
"name": "Updated Name",
}
addOps := map[string]interface{}{
"count": 5,
}
delOps := make(map[string]interface{})
remOps := []string{"tags"}
appendOps := make(map[string]interface{})
prependOps := make(map[string]interface{})
subtractOps := make(map[string]interface{})
dataOps := make(map[string]interface{})
params, err := builder.BuildUpdateItemParams(keys, setOps, addOps, delOps, remOps, appendOps, prependOps, subtractOps, dataOps, nil)
if err != nil {
t.Fatalf("Failed to build params: %v", err)
}
if params["TableName"] != "TestTable" {
t.Errorf("Expected TableName 'TestTable', got '%v'", params["TableName"])
}
updateExpr, ok := params["UpdateExpression"].(string)
if !ok {
t.Fatal("UpdateExpression is not a string")
}
// Check that SET, ADD, and REMOVE are in the expression
if updateExpr == "" {
t.Error("UpdateExpression is empty")
}
// Should have expression attribute names and values
if _, exists := params["ExpressionAttributeNames"]; !exists {
t.Error("ExpressionAttributeNames not found")
}
if _, exists := params["ExpressionAttributeValues"]; !exists {
t.Error("ExpressionAttributeValues not found")
}
// Default return value should be ALL_NEW
if params["ReturnValues"] != "ALL_NEW" {
t.Errorf("Expected ReturnValues 'ALL_NEW', got '%v'", params["ReturnValues"])
}
}
func TestBuildDeleteItemParams(t *testing.T) {
schema := &Schema{
Service: "TestService",
Entity: "TestEntity",
Table: "TestTable",
Attributes: map[string]*AttributeDefinition{
"id": {Type: AttributeTypeString, Required: true},
},
Indexes: map[string]*IndexDefinition{
"primary": {
PK: FacetDefinition{Field: "pk", Facets: []string{"id"}},
},
},
}
entity, err := NewEntity(schema, nil)
if err != nil {
t.Fatalf("Failed to create entity: %v", err)
}
builder := NewParamsBuilder(entity)
keys := Keys{"id": "test-123"}
params, err := builder.BuildDeleteItemParams(keys, nil)
if err != nil {
t.Fatalf("Failed to build params: %v", err)
}
if params["TableName"] != "TestTable" {
t.Errorf("Expected TableName 'TestTable', got '%v'", params["TableName"])
}
if _, exists := params["Key"]; !exists {
t.Error("Key not found in params")
}
}
func TestBuildQueryParams(t *testing.T) {
schema := &Schema{
Service: "TestService",
Entity: "TestEntity",
Table: "TestTable",
Attributes: map[string]*AttributeDefinition{
"id": {Type: AttributeTypeString, Required: true},
"mall": {Type: AttributeTypeString, Required: true},
"building": {Type: AttributeTypeString, Required: true},
"unit": {Type: AttributeTypeString, Required: true},
},
Indexes: map[string]*IndexDefinition{
"primary": {
PK: FacetDefinition{Field: "pk", Facets: []string{"id"}},
},
"units": {
Index: stringPtr("gsi1pk-gsi1sk-index"),
PK: FacetDefinition{Field: "gsi1pk", Facets: []string{"mall"}},
SK: &FacetDefinition{Field: "gsi1sk", Facets: []string{"building", "unit"}},
},
},
}
entity, err := NewEntity(schema, nil)
if err != nil {
t.Fatalf("Failed to create entity: %v", err)
}
builder := NewParamsBuilder(entity)
pkFacets := []interface{}{"EastPointe"}
params, err := builder.BuildQueryParams("units", pkFacets, nil, nil, nil, nil)
if err != nil {
t.Fatalf("Failed to build params: %v", err)
}
if params["TableName"] != "TestTable" {
t.Errorf("Expected TableName 'TestTable', got '%v'", params["TableName"])
}
if params["IndexName"] != "gsi1pk-gsi1sk-index" {
t.Errorf("Expected IndexName 'gsi1pk-gsi1sk-index', got '%v'", params["IndexName"])
}
keyCondition, ok := params["KeyConditionExpression"].(string)
if !ok {
t.Fatal("KeyConditionExpression is not a string")
}
// Single-table entity isolation: a query on an index whose SK exists but
// has no explicit condition/facets MUST still anchor to this entity's SK
// prefix via begins_with, otherwise the query would read sibling entities
// co-resident under the same GSI partition. Entity "TestEntity" (no
// version) with leading SK facet "building" -> "$testentity#building_".
expected := "gsi1pk = :pk AND begins_with(gsi1sk, :sk)"
if keyCondition != expected {
t.Errorf("Expected KeyConditionExpression '%s', got '%s'", expected, keyCondition)
}
vals := params["ExpressionAttributeValues"].(map[string]types.AttributeValue)
sk := vals[":sk"].(*types.AttributeValueMemberS).Value
if sk != "$testentity#building_" {
t.Errorf("Expected entity-isolation :sk '$testentity#building_', got '%s'", sk)
}
}
func TestBuildQueryParamsWithSortKey(t *testing.T) {
schema := &Schema{
Service: "TestService",
Entity: "TestEntity",
Table: "TestTable",
Attributes: map[string]*AttributeDefinition{
"id": {Type: AttributeTypeString, Required: true},
"mall": {Type: AttributeTypeString, Required: true},
"building": {Type: AttributeTypeString, Required: true},
},
Indexes: map[string]*IndexDefinition{
"units": {
Index: stringPtr("gsi1pk-gsi1sk-index"),
PK: FacetDefinition{Field: "gsi1pk", Facets: []string{"mall"}},
SK: &FacetDefinition{Field: "gsi1sk", Facets: []string{"building"}},
},
},
}
entity, err := NewEntity(schema, nil)
if err != nil {
t.Fatalf("Failed to create entity: %v", err)
}
builder := NewParamsBuilder(entity)
pkFacets := []interface{}{"EastPointe"}
skCondition := &sortKeyCondition{
operation: "begins_with",
values: []interface{}{"Building"},
}
params, err := builder.BuildQueryParams("units", pkFacets, nil, skCondition, nil, nil)
if err != nil {
t.Fatalf("Failed to build params: %v", err)
}
keyCondition, ok := params["KeyConditionExpression"].(string)
if !ok {
t.Fatal("KeyConditionExpression is not a string")
}
expected := "gsi1pk = :pk AND begins_with(gsi1sk, :sk)"
if keyCondition != expected {
t.Errorf("Expected KeyConditionExpression '%s', got '%s'", expected, keyCondition)
}
}