Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The stops may not be in the right order 1260/11 #1262

Closed
frodrigo opened this issue May 8, 2021 · 1 comment · May be fixed by #1274
Closed

The stops may not be in the right order 1260/11 #1262

frodrigo opened this issue May 8, 2021 · 1 comment · May be fixed by #1274
Assignees
@nlehuby
Labels
ready

Comments

@frodrigo
Copy link
Member

frodrigo commented May 8, 2021

This new analyser raise may false positive

EG https://www.openstreetmap.org/relation/2422779
Only two stops, the first is good, the last raise an issue
http://osmose.openstreetmap.fr/fr/error/65d681fc-ac08-4609-b04f-eb9b11f9a3d6
@nlehuby
Copy link
Member

nlehuby commented May 10, 2021

I think it's because the offset (ST_OffsetCurve) is not applied any more:
https://github.com/osm-fr/osmose-backend/pull/1254/files#diff-d73bbaa10a217bc33339087e3143f8337f95ca9e0bfcdccf87f022644eabd708R478 (and 490)

The offset reverses the linestring which is why we have to order desc when computing the order of the projected stop.

@nlehuby nlehuby mentioned this issue May 10, 2021
Merged
frodrigo added a commit to frodrigo/osmose-backend that referenced this issue May 11, 2021
@frodrigo
Reverse order in analyser_osmosis_relation_public_transport osm-fr#1262
b452ecb
@frodrigo frodrigo added the ready label May 11, 2021
nlehuby added a commit to nlehuby/osmose-backend that referenced this issue May 28, 2021
@nlehuby
fix order in public transport analysis
be97744 
put back the offset (to make sure the projection on the the ways is ok even if the same way is used multiple times in the relation)

Fix osm-fr#1262
@nlehuby nlehuby mentioned this issue May 28, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nlehuby nlehuby

Labels
ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix order in public transport analysis nlehuby/osmose-backend
2 participants
@nlehuby @frodrigo