Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: taker fee ingest is coupled to pools #344

Closed
p0mvn opened this issue Jun 25, 2024 — with Linear · 0 comments
Closed

bug: taker fee ingest is coupled to pools #344

p0mvn opened this issue Jun 25, 2024 — with Linear · 0 comments
Assignees

Comments

Copy link
Member

p0mvn commented Jun 25, 2024

An issue was observed where a taker fee for WBTC > allBTC is set to 0 (confirmed via CLI query) but the swap widget still shows it as 0.1%.

This is the investigation summary:

As of my knowledge, there is no cache for taker fees at any level of abstractions. Did a quick skim to validate that. The FE simply fetches the result from SQS quote after converting swap fee into the fiat value.
What seems to be the issue here is the way we propagate taker fee updates into SQS.
The way the ingestion works is that it attempts to retrieve for all combinations of denoms within pools that were modified in a block.
If there was no state update over the alloyed BTC pool for 20 minutes, the taker fee update would not get picked up.
This logic stems from the original implementation that pushed all data every block so this wasn't a problem.
Longer term, we should decouple the taker fee propagation from pool propagation. However, this feels like a low priority issue.

DoD

  • Decouple taker fee ingest from pool ingest
  • Unit test
  • Integration test
@p0mvn p0mvn self-assigned this Jun 25, 2024
@p0mvn p0mvn closed this as not planned Won't fix, can't repro, duplicate, stale Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant