Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quest database #113

Open
pmauldin opened this issue Jun 26, 2019 · 4 comments
Open

Quest database #113

pmauldin opened this issue Jun 26, 2019 · 4 comments
Labels
enhancement help wanted quests Anything to do with the quest data, API or builder

Comments

@pmauldin
Copy link

Similar to #16, it would be nice to add a dataset for quests to osrsbox-db. The data on the wiki for quests is pretty well structured, so that portion shouldn't be too difficult.

@pmauldin
Copy link
Author

I'm working on a tool that needs an API for OSRS quests, and to my surprise I couldn't find anything online that exists for that! So I'd love to help contribute to this project so more people can have access to it.
Tomorrow I'll clone the repo and spend some time digging through to get an understanding of how everything works, then I think it would be great to discuss how this work can be planned and broken up into separate work items.

@osrsbox
Copy link
Owner

osrsbox commented Jun 29, 2019

Hey @pmauldin - thanks for opening this issue, which formalizes our previous discussion about adding the quest dataset to the osrsbox-db project. We should keep this issue open as the base issue for adding the quest data, and open any additional issues for tracking/adding any major tasks. I will add some issues soon that will document some tasks I will tackle relating to this project goal.

@osrsbox osrsbox added enhancement quests Anything to do with the quest data, API or builder labels Jun 29, 2019
@pmauldin
Copy link
Author

pmauldin commented Jul 5, 2019

@osrsbox Hey there! Wanted to let you know that I've started to do some of the work around parsing the wiki entries for quests on my fork. It's not quite ready for a PR yet, but I do have a branch up with the initial code and generated json files (under docs/quests-json). When you have some time, please take a look and let me know what you think. If it seems like I'm going in the right direction, I can keep working on the other fields.

https://github.com/pmauldin/osrsbox-db/tree/quests-builder

@osrsbox
Copy link
Owner

osrsbox commented Feb 21, 2020

Just to keep everyone in the loop... The idea of the quest database is still something that I want to add to the project... it is just difficult to keep the project up-to-date weekly and is taking a lot of my time. This weeks update took nearly 4 hours due to major OSRS Wiki changes. Nevertheless, since the RESTful API release has been somewhat smooth, and is complete.. this issue is back on the table to get done. The following steps outline my plan:

  • Add schema-quests.json as a Cerberus schema to the schema repository (see: https://github.com/osrsbox/schemas)
  • Add quests_api to the osrsbox directory, and package, that matches the Cerberus schema
  • These were both done in the past, but the project updates (switching to Cerberus instead of JSON Schema, resulted in changes) have required a rewrite of these, previously implemented, solutions
  • Start development (branch?) of this repository that includes a builder/quests module to extract and parse quest data from the wiki to this project

Expect to see some issues being posted that link to this issue, to get the all rolling on implementing the quest database.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement help wanted quests Anything to do with the quest data, API or builder
Projects
None yet
Development

No branches or pull requests

2 participants