ui: allow items with no interactive elements to skip the unique focus requirement

fixes #1811

Author: jcelerier

src/plugins/score-lib-process/Process/Dataflow/NodeItem.cpp

@@ -657,10 +657,12 @@ void NodeItem::mousePressEvent(QGraphicsSceneMouseEvent* event)
     nodeItemInteraction = Interaction::Move;
   }
 
-  if(m_presenter)
+  if(m_presenter && m_model.flags() & Process::ProcessFlags::ItemRequiresUniqueFocus)
+  {
     m_context.focusDispatcher.focus(m_presenter);
-
+  }
   score::SelectionDispatcher{m_context.selectionStack}.select(m_model);
+
   event->accept();
 }
 namespace

src/plugins/score-lib-process/Process/LayerPresenter.cpp

@@ -63,7 +63,9 @@ void LayerPresenter::handlePresetDrop(const QPointF&, const QMimeData& mime)
 
 void LayerPresenter::requestFocus()
 {
-  m_context.context.focusDispatcher.focus(this);
+  if(this->m_process.flags() & Process::ProcessFlags::ItemRequiresUniqueFocus)
+    m_context.context.focusDispatcher.focus(this);
+  score::SelectionDispatcher{m_context.context.selectionStack}.select(m_process);
 }
 
 bool LayerPresenter::focused() const

src/plugins/score-lib-process/Process/ProcessFlags.hpp

@@ -52,6 +52,9 @@ enum ProcessFlags : int64_t
   //! The process is recordable
   Recordable = SCORE_FLAG(11),
 
+  //! The process has an editable widget which must unfocus & unselect other items
+  ItemRequiresUniqueFocus = SCORE_FLAG(12),
+
   SupportsLasting = SupportsTemporal | TimeIndependent,
   ExternalEffect
   = SupportsTemporal | TimeIndependent | RequiresCustomData | ControlSurface,

src/plugins/score-plugin-automation/Automation/AutomationProcessMetadata.hpp

@@ -19,4 +19,5 @@ PROCESS_METADATA(
     "ossia score", (QStringList{"Curve", "Automation"}), {},
     {std::vector<Process::PortType>{Process::PortType::Message}},
     QUrl("https://ossia.io/score-docs/in-depth/automations.html"),
-    Process::ProcessFlags::SupportsTemporal)
+    Process::ProcessFlags::SupportsTemporal
+        | Process::ProcessFlags::ItemRequiresUniqueFocus)

src/plugins/score-plugin-mapping/Mapping/MappingProcessMetadata.hpp

@@ -18,4 +18,5 @@ PROCESS_METADATA(
     {std::vector<Process::PortType>{Process::PortType::Message}},
     {std::vector<Process::PortType>{Process::PortType::Message}},
     QUrl("https://ossia.io/score-docs/processes/2Dspline.html#generating-a-curve"),
-    Process::ProcessFlags::SupportsLasting)
+    Process::ProcessFlags::SupportsLasting
+        | Process::ProcessFlags::ItemRequiresUniqueFocus)

src/plugins/score-plugin-midi/Midi/MidiProcessMetadata.hpp

@@ -14,4 +14,5 @@ PROCESS_METADATA(
     "MIDI note playback", "ossia score", {}, {},
     {std::vector<Process::PortType>{Process::PortType::Midi}},
     QUrl("https://ossia.io/score-docs/processes/piano-roll.html#piano-roll"),
-    Process::ProcessFlags::SupportsTemporal | Process::ProcessFlags::PutInNewSlot)
+    Process::ProcessFlags::SupportsTemporal | Process::ProcessFlags::PutInNewSlot
+        | Process::ProcessFlags::ItemRequiresUniqueFocus)

src/plugins/score-plugin-scenario/Scenario/Process/ScenarioProcessMetadata.hpp

@@ -14,4 +14,5 @@ PROCESS_METADATA(
     Process::ProcessCategory::Structure, "Structure", "Temporal structure",
     "ossia score", {}, {}, {},
     QUrl("https://ossia.io/score-docs/processes/scenario.html#scenario"),
-    Process::ProcessFlags::SupportsTemporal | Process::ProcessFlags::PutInNewSlot)
+    Process::ProcessFlags::SupportsTemporal | Process::ProcessFlags::PutInNewSlot
+        | Process::ProcessFlags::ItemRequiresUniqueFocus)

src/plugins/score-plugin-ui/Ui/ValueDisplay.hpp

@@ -45,7 +45,7 @@ struct Node
         QGraphicsItem* parent)
         : Process::EffectLayerView{parent}
     {
-      setAcceptedMouseButtons({});
+      setAcceptedMouseButtons(Qt::NoButton);
 
       const Process::PortFactoryList& portFactory
           = doc.app.interfaces<Process::PortFactoryList>();