Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add Timing Data to Parsing Results #664

Closed
AlexWeinstein92 opened this issue Sep 17, 2024 · 3 comments
Closed

[FEATURE] Add Timing Data to Parsing Results #664

AlexWeinstein92 opened this issue Sep 17, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@AlexWeinstein92
Copy link
Collaborator

Is your feature already requested in another issue?

No

Is your feature a defect?

No

Is your feature request related to a problem? Please describe.

How to display timing results to users in the IDEA plugin

Describe the solution you'd like

Timing results should be either packed into PassesResult or else returned along with it as a tuple or other structure

@AlexWeinstein92 AlexWeinstein92 added the enhancement New feature or request label Sep 17, 2024
@reid-spencer reid-spencer self-assigned this Sep 18, 2024
@reid-spencer reid-spencer removed the enhancement New feature or request label Sep 22, 2024
@reid-spencer reid-spencer added the RIDDL label Sep 23, 2024 — with Linear
Copy link
Contributor

How to display timing results to users in the IDEA plugin

I think the correct way to show timing data is the same way it is done in riddlc: in the logged output. That is the IDEA plugin's textual output log should contain the timing data exactly the way riddlc would have logged it. Thus, it isn't necessary to change 100 apis to include timing data.

@reid-spencer reid-spencer added enhancement New feature or request and removed RIDDL labels Oct 28, 2024
@reid-spencer reid-spencer added this to the 1.0 - First Full Release milestone Oct 29, 2024
@reid-spencer
Copy link
Contributor

@AlexWeinstein92 - Do you concur with the above analysis? Just use the Logger? If so, please close this Issue.

Copy link
Contributor

Insufficient responses. Closing this in favor of only putting out timing in the Logger.

@reid-spencer reid-spencer closed this as not planned Won't fix, can't repro, duplicate, stale Dec 2, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in riddl Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants