joinMuc history maxstanzas: 0 ignored #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

juliendangers opened this issue Dec 12, 2016 · 0 comments

Contributor

juliendangers commented Dec 12, 2016 •

edited

Loading

Hello,

I'm facing an issue with joinMuc history field. In a specific case I explicitly need to ask for 0 maxstanzas, but the following condition https://github.com/otalk/jxt-xmpp/blob/master/src/muc.js#L221 will ignore 0.

Could we add a check on option's type instead ? Or how would you solve this ? I'd be happy to create a PR ;)

(I'm sending "0" to bypass the condition, but I don't think it's a good solution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment