Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interesting Cursor Transform Work by Robert Lord #27

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

curran
Copy link

@curran curran commented Apr 9, 2019

Faced with the challenge of implementing presence for text0 strings embedded deep within json0 documents, I was perusing the json0 forks network and stumbled upon this quite interesting work by @lord.

I don't fully understand what the changes here are really doing, but I have a suspicion it may be an interesting lead. I'm creating a PR so it's easy to see the changes, and any interested parties can discuss here.

Related:

@curran curran mentioned this pull request Apr 9, 2019
@houshuang
Copy link

houshuang commented Apr 9, 2019 via email

@lord
Copy link

lord commented Apr 10, 2019

Oh jeez, this was from a long time ago! Happy to answer whatever questions I can about it, but honestly considering how little I remember, you're basically reading the code with the same eyes that I am.

@houshuang
Copy link

@lord Thanks for sharing. Do you have any code, or even snippets, of where you were using these functions (generating events etc, displaying in the UI etc)? I'm trying to wrap my head around how this interacts with the ideas from the @Teamwork approach to shared cursors/presence, they also use transformCursors, but they had to fork ShareDB to add a concept of presence, which you did not (I'm assuming?).

Thanks!

@lord
Copy link

lord commented Apr 10, 2019

Yeeea, I can try to find some code, but no promises. IIRC my concept of presence was represented as JSON objects in the doc itself, which were automatically added and removed when clients joined and left by some Feathers.js hook?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants