Skip to content
This repository has been archived by the owner on Nov 27, 2021. It is now read-only.

RedisSessions are not removed from memory due to incompatible type comparison #7

Open
jianping-roth opened this issue Sep 3, 2014 · 0 comments
Open

RedisSessions are not removed from memory due to incompatible type comparison #7

jianping-roth opened this issue Sep 3, 2014 · 0 comments

Comments

@jianping-roth
Copy link

RedisSessionIdManager.scavenge(...) uses a Long value (0L) to compare with a Boolean returned by Jedis.exists(key) and therefore the sessions are not able to be removed from SessionIdManagerSkeleton.sessions
trasa added a commit to trasa/jetty-session-redis that referenced this issue Jan 14, 2016
@trasa
Use Bool, not Long, to determine if session key exists
b5b7eb7 
This class calls jedis.exists() to determine if a session key has
expired or not - but was comparing the return value vs. 0L
instead of vs. a boolean false, so RedisSessions would never be
scavenged, leaking resources.

See:
ovea-deprecated#7
trasa added a commit to trasa/jetty-session-redis that referenced this issue Jan 14, 2016
@trasa
Use Bool, not Long, to determine if session key exists
c556808 
This class calls jedis.exists() to determine if a session key has
expired or not - but was comparing the return value vs. 0L
instead of vs. a boolean false, so RedisSessions would never be
scavenged, leaking resources.

See:
ovea-deprecated#7
trasa added a commit to trasa/jetty-session-redis that referenced this issue Jan 14, 2016
@trasa
Use Bool, not Long, to determine if session key exists
41184c5 
This class calls jedis.exists() to determine if a session key has
expired or not - but was comparing the return value vs. 0L
instead of vs. a boolean false, so RedisSessions would never be
scavenged, leaking resources.

See:
ovea-deprecated#7
trasa added a commit to trasa/jetty-session-redis that referenced this issue Jan 14, 2016
@trasa
Use Bool, not Long, to determine if session key exists
2eda993 
This class calls jedis.exists() to determine if a session key has
expired or not - but was comparing the return value vs. 0L
instead of vs. a boolean false, so RedisSessions would never be
scavenged, leaking resources.

See:
ovea-deprecated#7
@trasa trasa mentioned this issue Jan 14, 2016
Open
trasa added a commit to trasa/jetty-session-redis that referenced this issue Jan 14, 2016
@trasa
Use Bool, not Long, to determine if session key exists
057187e 
This class calls jedis.exists() to determine if a session key has
expired or not - but was comparing the return value vs. 0L
instead of vs. a boolean false, so RedisSessions would never be
scavenged, leaking resources.

See:
ovea-deprecated#7
@trasa trasa mentioned this issue Jan 14, 2016
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jianping-roth