Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileSink.write incoherencies #12194

Open
oguimbal opened this issue Jun 27, 2024 · 0 comments
Open

FileSink.write incoherencies #12194

oguimbal opened this issue Jun 27, 2024 · 0 comments
Labels
bug Something isn't working needs triage

Comments

@oguimbal
Copy link
Contributor

What version of Bun is running?

1.1.17+bb66bba1b

What platform is your computer?

Darwin 23.1.0 arm64 arm

What steps can reproduce the bug?

Run the below code, which is supposed to stream data through cat.

const p = Bun.spawn(['cat'], {
    stdin: 'pipe',
    stdout: 'pipe',
})

const r = p.stdout.getReader()
while (true) {
    const buf = new Uint8Array(1_000_000);
    const writeResult = p.stdin.write(buf);
    const written = await writeResult;
    console.log('writen', writeResult, ' => ', written);

    let i = 0;
    while (true) {
        const { value } = await r.read();
        i += value?.length ?? 0;
        if (i >= written) {
            break;
        }
    }
}

What is the expected behavior?

  1. I'd not expect FileSink.write to randomly return a promise
image
  1. I'd definitely not expect FileSink.write to return a number greater than the size of the buffer I passed to it

What do you see instead?

image

Additional information

No response

@oguimbal oguimbal added bug Something isn't working needs triage labels Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage
Projects
None yet
Development

No branches or pull requests

1 participant