Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResolveInfo not available in Query #1186

Open
fp-cfr opened this issue May 27, 2024 · 8 comments
Open

ResolveInfo not available in Query #1186

fp-cfr opened this issue May 27, 2024 · 8 comments

Comments

@fp-cfr
Copy link

fp-cfr commented May 27, 2024

Q A
Bug report? yes
Feature request? no
BC Break report? no
RFC? no
Version/Branch 1.1.0

Hello, I'm working on a large project with the update of the lib from version 1.0.0 to version 1.4.0. The following code is used which causes problems with the update:

#[GQL\Query(resolve: "query('CurrentClass:: getUser', info, args.id)")]
#[GQL\Arg('id', 'String!')]
public function getUser(ResolveInfo $info, string $id): User

Error:

Argument n°1 "$resolveInfo" on method "getUser" cannot be auto-guessed from the following type guessers:
[Type Hint] No corresponding GraphQL scalar,enum,input found for class "GraphQL\Type\Definition\ResolveInfo"

Since 1.1.0, is there another way to get ResolveInfo or is the observed behavior a bug?

@AlexOstrovsky
Copy link

I am having the same issue @Vincz any suggestion how to get ResolverInfo in Query in versions after 1.1.0?

@Vincz
Copy link
Collaborator

Vincz commented Jun 3, 2024

Hi guys. In this case, the argument should be ignored from arguments generation in the MetadataParser and it should be populated automatically by the ArgumentsTransformer.
Any of you want to work on this?

@AlexOstrovsky
Copy link

@Vincz TBO I looked into it a little and was able to skip arg 'info' in guessArgs of MetadataParser but then I don't see any way to know in ArgumentsTransformer if the Query has 'info' argument like in example: public function getUser(ResolveInfo $info, string $id) because generated function don't know about info as we skipped this argument. Would be so kind and ask someone who knows better what to do to look in it? Thanks.

@Vincz
Copy link
Collaborator

Vincz commented Jun 27, 2024

Hi @AlexOstrovsky! I'll try to look into it by the end of the week.

@AlexOstrovsky
Copy link

Hi @Vincz any luck with this?

@AlexOstrovsky
Copy link

@Vincz did you have time to look at this by any chance?

@Vincz
Copy link
Collaborator

Vincz commented Aug 8, 2024

Hi @AlexOstrovsky
You can find here an implementation: #1191
Let me know what you think

@AlexOstrovsky
Copy link

@Vincz tried your fork all works as expeted from my point of view

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants