[bug] Fullscreen blocks content if height is greater than screen height

[KristinAoki]

Full screen navigation is very hard to navigate and makes it impossible for users to scroll down completely and access the content. It completely hides the buttons making it impossible to move forward. They have to exit full screen to continue to navigate.

Happens only on certain devices (like a laptop), does not happen as often at higher resolutions.

The solution would be to have the height of <div class="scorm-pane " /> updated to the screen height if it is less than the saved height. The following changes will need to be made:

1. openedx-scorm-xblock/openedxscorm/static/js/src/scormxblock.js

   Lines 54 to 62 in ea54a52

   	function onFullscreenChange(e) {
   	if (isFullscreen()) {
   	$(e.target).addClass("fullscreen-enabled");
   	} else {
   	$(e.target).removeClass("fullscreen-enabled");
   	}
   	// This is required to trigger the actual content resize in some packages
   	window.dispatchEvent(new Event('resize'));
   	}

   
   Update the function to include height changes

function onFullscreenChange(e) {
        if (isFullscreen()) {
            $(e.target).addClass("fullscreen-enabled");
            // NEW LINE
            if (settings.block_height > screen.height) {
                $(e.target).css("height", screen.height);
            }
        } else {
            $(e.target).removeClass("fullscreen-enabled");
            // NEW LINE
            $(e.target).css("height", settings.block_height);
        }
        // This is required to trigger the actual content resize in some packages
        window.dispatchEvent(new Event('resize'));
}

2. openedx-scorm-xblock/openedxscorm/scormxblock.py

   Lines 237 to 246 in ea54a52

   	frag.initialize_js(
   	"ScormXBlock",
   	json_args={
   	"scorm_version": self.scorm_version,
   	"popup_on_launch": self.popup_on_launch,
   	"popup_width": self.width or 800,
   	"popup_height": self.height or 800,
   	"scorm_data": self.scorm_data,
   	},
   	)

   
   Add block_height to json_args

"block_height": self.height or 450,

[DawoudSheraz]

@Danyal-Faheem FYI