Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MP Item Spawns - Convert SP items to fixed timer spawns #205

Open
tobiasksu opened this issue Jan 15, 2022 · 6 comments
Open

MP Item Spawns - Convert SP items to fixed timer spawns #205

tobiasksu opened this issue Jan 15, 2022 · 6 comments
Assignees
Labels
enhancement New feature or request Multiplayer General multiplayer issues. needs more info There is not enough information to reproduce the issue.

Comments

@tobiasksu
Copy link
Collaborator

As an extension of Issue #200 and previous work on Miasmic's "arena" mod, I'd like to see the following for how SP item spawns are handled in MP:

  • SP item spawn with default attributes (respawns = false, index = 0) converted to a network sync'd one-time pickup which is immediately available on level load, instead of current mostly undefined state (as of olmod 0.5.4). This is most typical of someone accidentally placing an SP item spawn.
  • Use the "respawns" field to specify whether it's a one-time pickup or should respawn after pickup.
  • If respawns=true => Use the "index" field to specify the duration (in seconds) to wait to respawn the same item
  • If respawns=false => Use the "index" field to specify the duration after the match begins to spawn the item

This works in conjunction with the existing randomized spawns we have always used in MP levels, so can be mix & match, all randomized, or all specific item spawns on timers.

image

@tobiasksu tobiasksu added the enhancement New feature or request label Jan 15, 2022
@tobiasksu tobiasksu self-assigned this Jan 15, 2022
@tobiasksu tobiasksu added the Multiplayer General multiplayer issues. label Jan 15, 2022
@roncli roncli added the needs more info There is not enough information to reproduce the issue. label Jan 16, 2022
@roncli
Copy link
Member

roncli commented Jan 16, 2022

I am uncomfortable using something called "index" for a timer. What is this index normally used for?

@tobiasksu
Copy link
Collaborator Author

tobiasksu commented Jan 17, 2022

It's unused, always 0 (I'll double check but I want to say Arne also uses the index field on N000 mine entity for LevelPost swapping)

@roncli
Copy link
Member

roncli commented Jan 23, 2022

I can't find any evidence that EntityPropsItem is even used. 🤔 How do you intend to get the value read?

@tobiasksu
Copy link
Collaborator Author

I won't be around a computer until Monday but I have a working commit I checked in earlier this week but haven't PR'd until I can stress test it more. (Have only really tested it against TBDB Arena, Ascent, and stock maps)

tobiasksu@181a854

@roncli
Copy link
Member

roncli commented Feb 3, 2022

If you haven't yet, put this into a PR, and I'll go over it. :)

@roncli
Copy link
Member

roncli commented Aug 24, 2022

@tobiasksu Does #203 fix this in 0.5.5?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Multiplayer General multiplayer issues. needs more info There is not enough information to reproduce the issue.
Projects
None yet
Development

No branches or pull requests

2 participants