Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import 8c90792f61: Reverting custom shader management to original developer>enable procedural materials (by Caitlyn) #419

Open
daleglass opened this issue Aug 5, 2022 · 0 comments
Labels
automanaged Managed by a bot. Title and body are overwritten. Tags may be modified.

Comments

@daleglass
Copy link

This is an automated proposal to look at a commit made by Caitlyn and import it into Overte

Commit: 8c90792
Author: Caitlyn
Date: Tue, 05 May 2020 12:10
Reverting custom shader management to original developer>enable procedural materials


Stats:

Filename Stats Lines Added Removed Lines in blame
interface/src/Application.cpp 6 3 3 3
interface/src/Menu.cpp 31 18 13 13
interface/src/Menu.h 4 3 1 1
interface/src/PerformanceManager.cpp 8 4 4 4
interface/src/scripting/RenderScriptingInterface.cpp 74 17 57 3
interface/src/scripting/RenderScriptingInterface.h 54 18 36 7
interface/src/ui/PreferencesDialog.cpp 268 147 121 136
libraries/entities-renderer/src/RenderableMaterialEntityItem.cpp 64 29 35 29
libraries/entities-renderer/src/RenderableShapeEntityItem.cpp 92 44 48 39
libraries/procedural/src/procedural/Procedural.cpp 124 60 64 60
libraries/procedural/src/procedural/Procedural.h 81 41 40 41
libraries/procedural/src/procedural/ProceduralMaterialCache.cpp 95 56 39 56
libraries/procedural/src/procedural/ProceduralSkybox.cpp 14 7 7 7
libraries/qml/src/qml/impl/TextureCache.cpp 1429 1308 121 19
libraries/qml/src/qml/impl/TextureCache.h 283 230 53 5
libraries/render-utils/src/MeshPartPayload.cpp 184 95 89 87
libraries/render-utils/src/MeshPartPayload.h 75 49 26 48
17 files - 2886 2129 757 558

To work on this, please assign the issue to yourself, then look at the commit and decide whether this would be a good addition to Overte.

  • If the commit is useful, tag it with "Tivoli: Keep", and keep it open until it's merged.
  • If the commit is not useful, tag it with "Tivoli: Discard", and close it.
  • If the commit is not useful right now, but might be later, tag it with "Tivoli: Maybe later", and close it.
  • If it's hard to decide, tag it with "Tivoli: Discuss", and keep it open.

Useful commits should be submitted as a PR against Overte. Tag this issue in PR, so that it's automatically closed once the PR is merged.

You can cherry-pick this issue with this command:

git cherry-pick 8c90792f61960dc44af4df144cb8d2ddf23d24b6
@daleglass daleglass added the automanaged Managed by a bot. Title and body are overwritten. Tags may be modified. label Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automanaged Managed by a bot. Title and body are overwritten. Tags may be modified.
Projects
None yet
Development

No branches or pull requests

1 participant