Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import 9cb5638c44: Updated qml for toolbar and window frame (by Maki) #426

Open
daleglass opened this issue Aug 5, 2022 · 0 comments
Open
Labels
automanaged Managed by a bot. Title and body are overwritten. Tags may be modified.

Comments

@daleglass
Copy link

This is an automated proposal to look at a commit made by Maki and import it into Overte

Commit: 9cb5638
Author: Maki
Date: Tue, 05 May 2020 21:58
Updated qml for toolbar and window frame

Stats:

Filename Stats Lines Added Removed Lines in blame
interface/resources/qml/hifi/toolbars/Toolbar.qml 5 2 3 2
interface/resources/qml/stylesUit/HifiConstants.qml 2 1 1 1
interface/resources/qml/windows/Decoration.qml 10 5 5 4
interface/resources/qml/windows/DefaultFrameDecoration.qml 68 34 34 34
interface/resources/qml/windows/Frame.qml 10 7 3 7
interface/resources/qml/windows/ToolFrameDecoration.qml 8 4 4 ⚠ 0
6 files - 103 53 50 48

To work on this, please assign the issue to yourself, then look at the commit and decide whether this would be a good addition to Overte.

  • If the commit is useful, tag it with "Tivoli: Keep", and keep it open until it's merged.
  • If the commit is not useful, tag it with "Tivoli: Discard", and close it.
  • If the commit is not useful right now, but might be later, tag it with "Tivoli: Maybe later", and close it.
  • If it's hard to decide, tag it with "Tivoli: Discuss", and keep it open.

Useful commits should be submitted as a PR against Overte. Tag this issue in PR, so that it's automatically closed once the PR is merged.

You can cherry-pick this issue with this command:

git cherry-pick 9cb5638c44fbd9d81654b6acd52a4bef4f2e98d6
@daleglass daleglass added the automanaged Managed by a bot. Title and body are overwritten. Tags may be modified. label Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automanaged Managed by a bot. Title and body are overwritten. Tags may be modified.
Projects
None yet
Development

No branches or pull requests

1 participant