chore(okms): apply vitestEslintConfig rules

mathieumousnier · mathieumousnier · commit 49950dd07e78 · 2025-11-21T10:32:20.000+01:00
ref: #MANAGER-19870

Signed-off-by: Mathieu Mousnier &lt;mathieu.mousnier.ext@ovhcloud.com&gt;
diff --git a/packages/manager/apps/okms/eslint.config.mjs b/packages/manager/apps/okms/eslint.config.mjs
@@ -6,10 +6,6 @@ export default eslintSharedConfig;
 
 
 ## Progressive adoption ##
-import { typescriptEslintConfig } from '@ovh-ux/manager-static-analysis-kit/eslint/typescript';
-import { javascriptEslintConfig } from '@ovh-ux/manager-static-analysis-kit/eslint/javascript';
-import { reactEslintConfig } from '@ovh-ux/manager-static-analysis-kit/eslint/react';
-import { prettierEslintConfig } from '@ovh-ux/manager-static-analysis-kit/eslint/prettier';
 
 import {
   complexityJsxTsxConfig,
@@ -19,14 +15,14 @@ import { cssEslintConfig } from '@ovh-ux/manager-static-analysis-kit/eslint/css'
 import { htmlEslintConfig } from '@ovh-ux/manager-static-analysis-kit/eslint/html';
 import { importEslintConfig } from '@ovh-ux/manager-static-analysis-kit/eslint/imports';
 import { checkFileEslintConfig } from '@ovh-ux/manager-static-analysis-kit/eslint/naming-conventions';
-import { vitestEslintConfig } from '@ovh-ux/manager-static-analysis-kit/eslint/tests';
 */
 import { a11yEslintConfig } from '@ovh-ux/manager-static-analysis-kit/eslint/a11y';
 import { javascriptEslintConfig } from '@ovh-ux/manager-static-analysis-kit/eslint/javascript';
 import { prettierEslintConfig } from '@ovh-ux/manager-static-analysis-kit/eslint/prettier';
 import { reactEslintConfig } from '@ovh-ux/manager-static-analysis-kit/eslint/react';
 import { tailwindJsxConfig } from '@ovh-ux/manager-static-analysis-kit/eslint/tailwind-jsx';
 import { tanStackQueryEslintConfig } from '@ovh-ux/manager-static-analysis-kit/eslint/tanstack';
+import { vitestEslintConfig } from '@ovh-ux/manager-static-analysis-kit/eslint/tests';
 import { typescriptEslintConfig } from '@ovh-ux/manager-static-analysis-kit/eslint/typescript';
 
 export default [
@@ -64,4 +60,19 @@ export default [
       'tailwindcss/no-unnecessary-arbitrary-value': 'off',
     },
   },
+  /* ------------------------------------------------------------------------ */
+  /* Vitest Rules                                                     */
+  /* ------------------------------------------------------------------------ */
+  {
+    ...vitestEslintConfig,
+    rules: {
+      ...(vitestEslintConfig.rules ?? {}),
+      'vitest/expect-expect': [
+        'error',
+        {
+          assertFunctionNames: ['expect*', 'assert*'],
+        },
+      ],
+    },
+  },
 ];
diff --git a/packages/manager/apps/okms/src/common/components/okms-dashboard/billing-tile/BillingTile.spec.tsx b/packages/manager/apps/okms/src/common/components/okms-dashboard/billing-tile/BillingTile.spec.tsx
@@ -71,7 +71,7 @@ describe('OKMS Billing Tile test suite', () => {
   ];
 
   it.each(useCases)(
-    'should display tile content and have productType $productType resiliate link $resiliateLink ',
+    'should display tile content and have productType $productType resiliate link $resiliateLink',
     async ({ productType, resiliateLink }) => {
       vi.mocked(useProductType).mockReturnValue(productType);
       const user = userEvent.setup();
diff --git a/packages/manager/apps/okms/src/modules/key-management-service/hooks/breadcrumb/useBreadcrumb.spec.tsx b/packages/manager/apps/okms/src/modules/key-management-service/hooks/breadcrumb/useBreadcrumb.spec.tsx
@@ -84,7 +84,7 @@ describe('useBreadcumb test suite', () => {
     expect(result.current[1].navigateTo).toEqual(items[1].navigateTo);
   });
 
-  it('should not have a navigateTo url when no corresponding given item is found ', () => {
+  it('should not have a navigateTo url when no corresponding given item is found', () => {
     // given
     const { result } = renderHook(() => useBreadcrumb({ items }));
 
diff --git a/packages/manager/apps/okms/src/modules/key-management-service/hooks/service-key/useServiceKeyOperationsTranslations.spec.tsx b/packages/manager/apps/okms/src/modules/key-management-service/hooks/service-key/useServiceKeyOperationsTranslations.spec.tsx
@@ -12,7 +12,7 @@ vi.mock('react-i18next', () => ({
   }),
 }));
 
-describe('get service key operations translation ', () => {
+describe('get service key operations translation', () => {
   const useCases: {
     operation: OkmsServiceKeyOperations;
     translationKey: string;
diff --git a/packages/manager/apps/okms/src/modules/key-management-service/hooks/service-key/useServiceKeyTypeTranslations.spec.tsx b/packages/manager/apps/okms/src/modules/key-management-service/hooks/service-key/useServiceKeyTypeTranslations.spec.tsx
@@ -12,7 +12,7 @@ vi.mock('react-i18next', () => ({
   }),
 }));
 
-describe('get service key type translation ', () => {
+describe('get service key type translation', () => {
   const useCases: {
     type: OkmsKeyTypes;
     translationKey: string;
diff --git a/packages/manager/apps/okms/src/modules/key-management-service/pages/create/CreateKms.spec.tsx b/packages/manager/apps/okms/src/modules/key-management-service/pages/create/CreateKms.spec.tsx
@@ -40,7 +40,7 @@ const pickRegion = async (user: UserEvent) => {
   await act(() => user.click(firstRegionOption));
 };
 
-const waitOrderButtonToBeEnabled = async () => {
+const expectOrderButtonToBeEnabled = async () => {
   await waitFor(() => {
     expect(screen.getByTestId(CREATE_KMS_TEST_IDS.CTA_ORDER)).toBeEnabled();
   });
@@ -90,7 +90,7 @@ describe('KMS creation page test suite', () => {
 
     await pickRegion(user);
 
-    await waitOrderButtonToBeEnabled();
+    await expectOrderButtonToBeEnabled();
   });
 
   it('should open the order modal on order button click', async () => {
@@ -99,7 +99,7 @@ describe('KMS creation page test suite', () => {
 
     await pickRegion(user);
 
-    await waitOrderButtonToBeEnabled();
+    await expectOrderButtonToBeEnabled();
 
     // Click on order button
     await act(async () => {
diff --git a/packages/manager/apps/okms/src/modules/secret-manager/hooks/useBackToOkmsListUrl.spec.tsx b/packages/manager/apps/okms/src/modules/secret-manager/hooks/useBackToOkmsListUrl.spec.tsx
@@ -78,7 +78,7 @@ describe('useBackToOkmsListUrl tests suite', () => {
       expect(result.current).toBeNull();
     });
 
-    it('should return the okms List url when there is more than one kms on a region ', async () => {
+    it('should return the okms List url when there is more than one kms on a region', async () => {
       // GIVEN
       const mockedUrl = SECRET_MANAGER_ROUTES_URLS.okmsList(REGION_EU_WEST_RBX);
       mockGetOkmsList.mockResolvedValue([okmsRoubaix1Mock, okmsRoubaix2Mock]);
diff --git a/packages/manager/apps/okms/src/modules/secret-manager/hooks/useRegionSelector.spec.tsx b/packages/manager/apps/okms/src/modules/secret-manager/hooks/useRegionSelector.spec.tsx
@@ -154,14 +154,6 @@ describe('useRegionSelector tests suite', () => {
       expect(result.current.currentRegion).toEqual(sbgRegionOptionMock);
     });
 
-    it('should set current region based on useCurrentRegion result', async () => {
-      mockUseCurrentRegion.mockReturnValue(REGION_EU_WEST_SBG);
-
-      const { result } = await renderCustomHook('success');
-
-      expect(result.current.currentRegion).toEqual(sbgRegionOptionMock);
-    });
-
     it('should return first region as current when no current region is provided', async () => {
       mockUseCurrentRegion.mockReturnValue(undefined);
 
diff --git a/packages/manager/apps/okms/src/modules/secret-manager/pages/create-secret/SecretForm.component.spec.tsx b/packages/manager/apps/okms/src/modules/secret-manager/pages/create-secret/SecretForm.component.spec.tsx
@@ -99,7 +99,7 @@ describe('Secrets creation form test suite', () => {
       shouldButtonBeDisabled: false,
     },
   ])(
-    'should check the form validity for data: $data, path: $path and a selectedOkms: $selectedOkmsId ',
+    'should check the form validity for data: $data, path: $path and a selectedOkms: $selectedOkmsId',
     async ({ data, path, selectedOkmsId, shouldButtonBeDisabled }) => {
       // GIVEN
       const user = userEvent.setup();
diff --git a/packages/manager/apps/okms/src/modules/secret-manager/pages/drawers/create-version-drawer/CreateVersionDrawer.page.spec.tsx b/packages/manager/apps/okms/src/modules/secret-manager/pages/drawers/create-version-drawer/CreateVersionDrawer.page.spec.tsx
@@ -66,11 +66,12 @@ describe('Secret create version drawer page test suite', () => {
     const { container } = await renderPage();
 
     // Check disabled sumbit button
-    await getOdsButtonByLabel({
+    const button = await getOdsButtonByLabel({
       container,
       label: labels.common.actions.add,
       disabled: true,
     });
+    expect(button).toBeInTheDocument();
   });
 
   it('should display the current secret value', async () => {
diff --git a/packages/manager/apps/okms/src/modules/secret-manager/pages/okms-list/OkmsList.page.spec.tsx b/packages/manager/apps/okms/src/modules/secret-manager/pages/okms-list/OkmsList.page.spec.tsx
@@ -16,7 +16,7 @@ import { assertRegionSelectorIsVisible } from '@/modules/secret-manager/utils/te
 
 const mockPageUrl = SECRET_MANAGER_ROUTES_URLS.okmsList(regionWithMultipleOkms.region);
 
-const checkOkmsListPageToBeDisplayed = async (container: HTMLElement) => {
+const expectOkmsListPageToBeDisplayed = async (container: HTMLElement) => {
   const user = userEvent.setup();
 
   // Check the page title
@@ -44,7 +44,7 @@ describe('Okms List page test suite', () => {
   it('should display the okms listing page', async () => {
     const { container } = await renderTestApp(mockPageUrl);
 
-    await checkOkmsListPageToBeDisplayed(container);
+    await expectOkmsListPageToBeDisplayed(container);
   });
 
   it('should display the breadcrumb', async () => {
@@ -62,7 +62,7 @@ describe('Okms List page test suite', () => {
   it('should display the listing table with all columns', async () => {
     const { container } = await renderTestApp(mockPageUrl);
 
-    await checkOkmsListPageToBeDisplayed(container);
+    await expectOkmsListPageToBeDisplayed(container);
 
     const name = labels.listing.key_management_service_listing_name_cell;
     const id = labels.listing.key_management_service_listing_id_cell;
@@ -78,7 +78,7 @@ describe('Okms List page test suite', () => {
   it(`should navigate to the secret creation page on click on create a secret button`, async () => {
     const { container } = await renderTestApp(mockPageUrl);
 
-    const { user } = await checkOkmsListPageToBeDisplayed(container);
+    const { user } = await expectOkmsListPageToBeDisplayed(container);
 
     const button = await getOdsButtonByLabel({
       container,
@@ -95,7 +95,7 @@ describe('Okms List page test suite', () => {
   it('should navigate to the secrets listing page on click on okms name', async () => {
     const { container } = await renderTestApp(mockPageUrl);
 
-    const { user, okmsNameLink } = await checkOkmsListPageToBeDisplayed(container);
+    const { user, okmsNameLink } = await expectOkmsListPageToBeDisplayed(container);
 
     await act(async () => {
       await user.click(okmsNameLink);
@@ -112,7 +112,7 @@ describe('Okms List page test suite', () => {
 
       // manager redirects to the root page
       // then to the default region page that displays the okms list
-      await checkOkmsListPageToBeDisplayed(container);
+      await expectOkmsListPageToBeDisplayed(container);
     });
 
     it('when the region is not valid', async () => {
@@ -122,7 +122,7 @@ describe('Okms List page test suite', () => {
 
       // manager redirects to the root page
       // then to the default region page that displays the okms list
-      await checkOkmsListPageToBeDisplayed(container);
+      await expectOkmsListPageToBeDisplayed(container);
     });
   });
 
diff --git a/packages/manager/apps/okms/src/modules/secret-manager/pages/secret-list/SecretList.page.spec.tsx b/packages/manager/apps/okms/src/modules/secret-manager/pages/secret-list/SecretList.page.spec.tsx
@@ -42,6 +42,8 @@ const assertDatagridIsLoaded = async (container: HTMLElement) => {
 describe('Secret list page test suite', () => {
   it('should display the secrets list page', async () => {
     await renderPage();
+
+    await assertTextVisibility(labels.secretManager.secret_manager);
   });
 
   it('should display the breadcrumb', async () => {
@@ -102,7 +104,7 @@ describe('Secret list page test suite', () => {
     expect(dashboardPageLabels.length).toBeGreaterThan(0);
   });
 
-  it('should navigate to OKMS dashboard on click on "manage okms" button ', async () => {
+  it('should navigate to OKMS dashboard on click on "manage okms" button', async () => {
     // GIVEN
     const user = userEvent.setup();
     const { container } = await renderPage();
diff --git a/packages/manager/apps/okms/src/modules/secret-manager/pages/secret/version-list/VersionCells.component.spec.tsx b/packages/manager/apps/okms/src/modules/secret-manager/pages/secret/version-list/VersionCells.component.spec.tsx
@@ -79,12 +79,13 @@ describe('VersionCellId test suite', () => {
         const { container } = await renderVersionLink(version);
 
         // THEN
-        await getOdsButtonByLabel({
+        const link = await getOdsButtonByLabel({
           container,
           label: version.id.toString(),
           isLink: true,
           disabled: isLinkDisabled,
         });
+        expect(link).toBeInTheDocument();
       },
     );
   });
