feat(mrc): updating the price component with additional props #19810
+38
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aderghamov
requested review from
aboungnaseng-ovhcloud,
anooparveti and
helabenkhalfallah
chipp972
previously approved these changes
Oct 17, 2025
anooparveti
requested changes
Oct 17, 2025
Contributor
anooparveti
left a comment
anooparveti
left a comment
There was a problem hiding this comment.
@aderghamov, since we are too close to launch MUK v1, we will be releasing this after the launch of MUK v1. In the meantime, can you create a ticket on MRC board and come present it in Open office to understand the change. We will be able to review the code only after understanding the requirement.
github-actions
bot
added
the
has conflicts
aderghamov
force-pushed
the
feat/update-MRC-price
branch
from
d1e5ca6 to
8c4701d
Compare
github-actions
bot
removed
the
has conflicts
aderghamov
force-pushed
the
feat/update-MRC-price
branch
from
8c4701d to
2427de8
Compare
anooparveti
requested changes
Oct 27, 2025
Contributor
anooparveti
left a comment
anooparveti
left a comment
There was a problem hiding this comment.
Run tests / test (push) Failing after 17m
Lint Code Base / Lint Code Base (push) Failing after 23m
Can you correct the failing checks?
Also, i dont see any tests regarding the new features added, can you add them? And also add the stories on manager-wiki.
aderghamov
force-pushed
the
feat/update-MRC-price
branch
2 times, most recently
from
84020ed to
0d4ecce
Compare
…fix and freePriceLabel props ref: #MANAGER-15320 Signed-off-by: aderghamov <[email protected]>
aderghamov
force-pushed
the
feat/update-MRC-price
branch
from
0d4ecce to
ad8b3a6
Compare
github-actions
bot
added
the
has conflicts
chipp972
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #MANAGER-15320
Description
Ticket Reference: #...
Additional Information