Comment related bug report for HPUIInteractor.CanSelect override

ahmed-shariff · ahmed-shariff · commit 66655a973507 · 2024-01-12T14:29:28.000-08:00
diff --git a/Runtime/Interaction/HPUIInteractor.cs b/Runtime/Interaction/HPUIInteractor.cs
@@ -101,6 +101,8 @@ public override void GetValidTargets(List<IXRInteractable> targets)
             ListPool<IXRInteractable>.Release(recievedTargets);
         }
 
+        // NOTE: PokeInteractor has a bug where it doesn't account for the re-prioritization.
+        // See: https://forum.unity.com/threads/xrpokeinteractor-m_currentpoketarget-not-respecting-getvalidtargets-and-target-filters.1534039/#post-9571063
         /// <inheritdoc />
         public override bool CanSelect(IXRSelectInteractable interactable)
         {

Original file line number	Diff line number	Diff line change
`@@ -101,6 +101,8 @@ public override void GetValidTargets(List<IXRInteractable> targets)`
`101`	`101`	`ListPool<IXRInteractable>.Release(recievedTargets);`
`102`	`102`	`}`
`103`	`103`
	`104`	`+ // NOTE: PokeInteractor has a bug where it doesn't account for the re-prioritization.`
	`105`	`+ // See: https://forum.unity.com/threads/xrpokeinteractor-m_currentpoketarget-not-respecting-getvalidtargets-and-target-filters.1534039/#post-9571063`
`104`	`106`	`/// <inheritdoc />`
`105`	`107`	`public override bool CanSelect(IXRSelectInteractable interactable)`
`106`	`108`	`{`