Fix 'credits' and 'rail' optional attributes in ldmsd_controller prdcr_add #1234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@narategithub, @nichamon The 'reconnect' change conflicts with this change. Also, it looks like 'reconnect', and 'interval' were made optional by @nichamon's change which I'm not sure is correct. Could you guys resolve this please? |
…r_add 'credits' and 'rail' are optional attributes in prdcr_add command. They were accidentally listed under the required attribute list.
narategithub
force-pushed
the
prdcr-credits-fix
branch
from
b9802a9
to
ea76e76
Compare
|
@tom95858 the rebase is done. I talked with @nichamon, her PR #1233 moved 'reconnect' and 'interval' under the optional list because the user can specify either 'reconnect' or 'interval', until the 'interval' attribute is completely removed from the command. She also put logic in |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'credits' and 'rail' are optional attributes in prdcr_add command. They were accidentally listed under the required attribute list.